Skip to content

🧹 [Remove unnecessary allow(dead_code) on LogosToken] - #139

Merged
Tcode-Motion merged 1 commit into
mainfrom
fix-lexer-dead-code-18072627311787972106
Sep 15, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
fix-lexer-dead-code-18072627311787972106

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed the unnecessary #[allow(dead_code)] attribute from the LogosToken enum in compiler/lexer/src/lib.rs.

💡 Why: The LogosToken enum is fully utilized by the logos-derive macro for token generation and exhaustively matched in Lexer::map_logos_token. The attribute is redundant and removing it improves code clarity and ensures any actual dead code in the future would be properly flagged by the compiler.

✅ Verification: Verified by running the full workspace test suite (cargo test --workspace) and running cargo clippy --workspace --all-targets to ensure no functionality is broken and code is compliant.

✨ Result: A cleaner codebase with proper compiler warnings enabled for the LogosToken enum if dead code is introduced in the future.


PR created automatically by Jules for task 18072627311787972106 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 15, 2026 08:20
@Tcode-Motion
Tcode-Motion merged commit 30a58b0 into main Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant