Skip to content

🧹 Remove unwrap usage in web.rs standard library - #194

Merged
Tcode-Motion merged 2 commits into
mainfrom
fix/web-unwrap-health-6372023742653441678
Sep 22, 2026
Merged

Tcode-Motion merged 2 commits into
mainfrom
fix/web-unwrap-health-6372023742653441678

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Replaced the fragile unwrap() calls on tiny_http::Server::http(...) in the start and serve functions of web.rs with proper match statements that return a RuntimeError upon failure. We also explicitly replaced .unwrap() on hardcoded, infallible header parsing with .expect("valid header").
💡 Why: This improves maintainability and robustness. Unwrapping the server creation meant that if a port was already in use, the entire runtime would crash with a panic. By returning a RuntimeError, TechScript code can handle the failure gracefully. Additionally, we ensure SERVER_RUNNING is correctly reset to false in the error path to avoid poisoning global state.
✅ Verification: Ran cargo test --workspace --all-targets and verified all tests pass, including updated tests in stdlib_tests.rs that now check for RuntimeErrors instead of panics when attempting to bind to an in-use port.
✨ Result: The web server standard library functions are now safer, more reliable, and correctly propagate errors back to the caller instead of crashing the interpreter.


PR created automatically by Jules for task 6372023742653441678 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 22, 2026 07:52
@Tcode-Motion
Tcode-Motion merged commit 0d2b11e into main Sep 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant