🧹 Remove unwrap usage in web.rs standard library - #194
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
🎯 What: Replaced the fragile
unwrap()calls ontiny_http::Server::http(...)in thestartandservefunctions ofweb.rswith propermatchstatements that return aRuntimeErrorupon failure. We also explicitly replaced.unwrap()on hardcoded, infallible header parsing with.expect("valid header").💡 Why: This improves maintainability and robustness. Unwrapping the server creation meant that if a port was already in use, the entire runtime would crash with a panic. By returning a
RuntimeError, TechScript code can handle the failure gracefully. Additionally, we ensureSERVER_RUNNINGis correctly reset tofalsein the error path to avoid poisoning global state.✅ Verification: Ran
cargo test --workspace --all-targetsand verified all tests pass, including updated tests instdlib_tests.rsthat now check forRuntimeErrors instead of panics when attempting to bind to an in-use port.✨ Result: The web server standard library functions are now safer, more reliable, and correctly propagate errors back to the caller instead of crashing the interpreter.
PR created automatically by Jules for task 6372023742653441678 started by @Tcode-Motion