Skip to content

🧹 Extract shared home_dir to fix duplication - #197

Closed
Tcode-Motion wants to merge 1 commit into
mainfrom
cleanup-duplicate-home-dirs-1155596976972508230
Closed

Tcode-Motion wants to merge 1 commit into
mainfrom
cleanup-duplicate-home-dirs-1155596976972508230

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed duplicate home_dir function implementations across cli/src/commands/clean.rs, cli/src/commands/doctor.rs, cli/src/commands/repl.rs, and cli/src/config.rs. Created a shared utility in cli/src/dirs.rs and updated all call sites to use crate::dirs::home_dir().

💡 Why: Reduces code duplication, which improves the maintainability and readability of the codebase. It ensures consistent handling of the home_dir logic and makes future updates to it significantly simpler as it only exists in one place.

✅ Verification: Verified changes visually with git diff. Successfully ran cargo fmt --all and cargo test --workspace --all-targets to confirm no regressions. Successfully ran cargo clippy --workspace --all-targets -- -D warnings to verify lints pass.

✨ Result: A cleaner codebase with less duplication, no dead code, and centralized utility functions in the CLI crate.


PR created automatically by Jules for task 1155596976972508230 started by @Tcode-Motion

Replaces duplicated implementations of `mod dirs { ... }` in `clean.rs`, `doctor.rs`, `repl.rs`, and `config.rs` with a centralized utility in `cli/src/dirs.rs`. Updates call sites to reference `crate::dirs::home_dir()`.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion

Copy link
Copy Markdown
Owner Author

This branch has conflicts that must be resolved
https://github.com/Tcode-Motion/techscript/pull/197/conflicts) or the command line to resolve conflicts before continuing.

cli/src/commands/clean.rs

@google-labs-jules

Copy link
Copy Markdown
Contributor

This branch has conflicts that must be resolved
https://github.com/Tcode-Motion/techscript/pull/197/conflicts) or the command line to resolve conflicts before continuing.

cli/src/commands/clean.rs

I have resolved the merge conflicts in cli/src/commands/clean.rs and updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant