🧹 Extract shared home_dir to fix duplication - #197
Tcode-Motion wants to merge 1 commit into
Conversation
Replaces duplicated implementations of `mod dirs { ... }` in `clean.rs`, `doctor.rs`, `repl.rs`, and `config.rs` with a centralized utility in `cli/src/dirs.rs`. Updates call sites to reference `crate::dirs::home_dir()`.
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This branch has conflicts that must be resolved cli/src/commands/clean.rs |
I have resolved the merge conflicts in |
🎯 What: Removed duplicate
home_dirfunction implementations acrosscli/src/commands/clean.rs,cli/src/commands/doctor.rs,cli/src/commands/repl.rs, andcli/src/config.rs. Created a shared utility incli/src/dirs.rsand updated all call sites to usecrate::dirs::home_dir().💡 Why: Reduces code duplication, which improves the maintainability and readability of the codebase. It ensures consistent handling of the
home_dirlogic and makes future updates to it significantly simpler as it only exists in one place.✅ Verification: Verified changes visually with
git diff. Successfully rancargo fmt --allandcargo test --workspace --all-targetsto confirm no regressions. Successfully rancargo clippy --workspace --all-targets -- -D warningsto verify lints pass.✨ Result: A cleaner codebase with less duplication, no dead code, and centralized utility functions in the CLI crate.
PR created automatically by Jules for task 1155596976972508230 started by @Tcode-Motion