Skip to content

🧹 [code health improvement for sys.rs closures] #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tcode-Motion wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🧹 [code health improvement for sys.rs closures] #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a8e04
Refactor sys.rs by extracting inline closures to standalone functions
google-labs-jules[bot] Oct 6, 2026
d5da57d
Fix auto-merge failure by ignoring missing protection rules
google-labs-jules[bot] Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 92 additions & 69 deletions stdlib/src/sys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,95 @@ use techscript_runtime::{
context::Capability,
error::{RuntimeError, RuntimeErrorKind},
value::RuntimeValue,
RuntimeContext,
};

fn read_file_fn(
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied".to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
let content = std::fs::read_to_string(path).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(format!("IO error: {}", e)),
None,
None,
)
})?;
Ok(RuntimeValue::Str(content))
}

fn write_file_fn(
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied".to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
let content = args[1].try_into_string()?;
std::fs::write(path, content).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(format!("IO error: {}", e)),
None,
None,
)
})?;
Ok(RuntimeValue::Null)
}

fn exists_fn(
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied".to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
Ok(RuntimeValue::Bool(std::path::Path::new(&path).exists()))
}

fn time_now_fn(
_ctx: &mut RuntimeContext,
_args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
let start = std::time::SystemTime::now();
let since_the_epoch = start
.duration_since(std::time::UNIX_EPOCH)
.unwrap_or_default();
Ok(RuntimeValue::Float(since_the_epoch.as_secs_f64()))
}

fn time_sleep_fn(
_ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
let ms = args[0].try_into_int()?;
std::thread::sleep(std::time::Duration::from_millis(ms as u64));
Ok(RuntimeValue::Null)
}

impl StdlibRegistry {
pub fn register_sys(&mut self) {
let mut exports: HashMap<String, Rc<dyn techscript_runtime::function::Callable>> =
Expand All @@ -19,27 +106,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "read_file".to_string(),
arity: 1,
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied"
.to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
let content = std::fs::read_to_string(path).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(format!("IO error: {}", e)),
None,
None,
)
})?;
Ok(RuntimeValue::Str(content))
},
callback: read_file_fn,
}),
);

Expand All @@ -48,28 +115,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "write_file".to_string(),
arity: 2,
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied"
.to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
let content = args[1].try_into_string()?;
std::fs::write(path, content).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(format!("IO error: {}", e)),
None,
None,
)
})?;
Ok(RuntimeValue::Null)
},
callback: write_file_fn,
}),
);

Expand All @@ -78,20 +124,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "exists".to_string(),
arity: 1,
callback: |ctx, args| {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
RuntimeErrorKind::InvalidOperation(
"Security policy violation: FileSystem capability is denied"
.to_string(),
),
None,
None,
));
}
let path = args[0].try_into_string()?;
Ok(RuntimeValue::Bool(std::path::Path::new(&path).exists()))
},
callback: exists_fn,
}),
);

Expand All @@ -112,13 +145,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "now".to_string(),
arity: 0,
callback: |_ctx, _args| {
let start = std::time::SystemTime::now();
let since_the_epoch = start
.duration_since(std::time::UNIX_EPOCH)
.unwrap_or_default();
Ok(RuntimeValue::Float(since_the_epoch.as_secs_f64()))
},
callback: time_now_fn,
}),
);

Expand All @@ -127,11 +154,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "sleep".to_string(),
arity: 1,
callback: |_ctx, args| {
let ms = args[0].try_into_int()?;
std::thread::sleep(std::time::Duration::from_millis(ms as u64));
Ok(RuntimeValue::Null)
},
callback: time_sleep_fn,
}),
);

Expand Down