Skip to content

⚡ Optimize Dominator Analysis inner loop #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Oct 6, 2026
Merged

⚡ Optimize Dominator Analysis inner loop #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions compiler/optimizer/src/analysis/dominators.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,19 @@ impl DominatorAnalysis {
continue;
}

let mut new_dom = all_blocks.clone();
let mut new_dom: Option<HashSet<BlockId>> = None;
for &pred in &block.predecessors {
if let Some(pred_doms) = dominators.get(&pred) {
new_dom = new_dom.intersection(pred_doms).cloned().collect();
if let Some(mut current_dom) = new_dom.take() {
current_dom.retain(|x| pred_doms.contains(x));
new_dom = Some(current_dom);
} else {
new_dom = Some(pred_doms.clone());
}
}
}

let mut new_dom = new_dom.unwrap_or_else(|| all_blocks.clone());
new_dom.insert(block.id);

if let Some(old_doms) = dominators.get_mut(&block.id) {
Expand Down
Loading