Skip to content

🧹 [code health improvement] Remove dead code attribute in lexer - #237

Merged
github-actions[bot] merged 1 commit into
mainfrom
remove-dead-code-attribute-4739434527682246520
Oct 7, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
remove-dead-code-attribute-4739434527682246520

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed the #[allow(dead_code)] attribute from the LogosToken enum in compiler/lexer/src/lib.rs.
💡 Why: This improves maintainability by allowing the Rust compiler to legitimately check for and highlight unused enum variants, increasing code safety and preventing the accumulation of truly dead code over time.
✅ Verification: Verified by using head to check the file contents, running cargo check -p techscript_lexer, cargo build -p techscript_lexer --release, and cargo test -p techscript_lexer to ensure no regressions were introduced. Note that pre-existing build failures in the workspace (due to dependency version issues) are unrelated to this change and do not block its success.
✨ Result: A safer, more maintainable codebase that leverages the compiler's dead code analysis capabilities for the lexer's token definitions.


PR created automatically by Jules for task 4739434527682246520 started by @Tcode-Motion

Removed the `#[allow(dead_code)]` attribute from `compiler/lexer/src/lib.rs` to allow the Rust compiler to legitimately check for and highlight unused enum variants, increasing code safety.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 7, 2026 13:05
@github-actions
github-actions Bot merged commit f696604 into main Oct 7, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant