Repository navigation
🧹 [Remove unused parser code allowance] - #76
Conversation
This commit removes the `#[allow(dead_code)]` attribute from the `Parser` implementation in `compiler/parser/src/parser.rs`. It also removes the actual unused dead code (`current_span` and `prev_span` methods) and the subsequent unused `Span` import. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed the
#[allow(dead_code)]attribute from theParserimplementation, deleted the unusedcurrent_spanandprev_spanmethods, and removed the unusedSpanimport.💡 Why: Suppressing warnings with
#[allow(dead_code)]hides potential issues and clutters the codebase with unused functionality. Removing the dead code directly improves maintainability and readability.✅ Verification: Ran
cargo check -p techscript_parser,cargo fmt --all, andcargo test --workspaceto verify that no functionality was broken and no new warnings were introduced.✨ Result: A cleaner codebase with no unnecessary code allowances or unused code paths in the parser module.
PR created automatically by Jules for task 17790725839574516037 started by @Tcode-Motion