Skip to content

🧹 [Remove unused parser code allowance] - #76

Merged
Tcode-Motion merged 1 commit into
mainfrom
remove-dead-code-allowance-parser-17790725839574516037
Sep 8, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
remove-dead-code-allowance-parser-17790725839574516037

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed the #[allow(dead_code)] attribute from the Parser implementation, deleted the unused current_span and prev_span methods, and removed the unused Span import.
💡 Why: Suppressing warnings with #[allow(dead_code)] hides potential issues and clutters the codebase with unused functionality. Removing the dead code directly improves maintainability and readability.
✅ Verification: Ran cargo check -p techscript_parser, cargo fmt --all, and cargo test --workspace to verify that no functionality was broken and no new warnings were introduced.
✨ Result: A cleaner codebase with no unnecessary code allowances or unused code paths in the parser module.


PR created automatically by Jules for task 17790725839574516037 started by @Tcode-Motion

This commit removes the `#[allow(dead_code)]` attribute from the `Parser` implementation in `compiler/parser/src/parser.rs`. It also removes the actual unused dead code (`current_span` and `prev_span` methods) and the subsequent unused `Span` import.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 15:59
@Tcode-Motion
Tcode-Motion merged commit 78cecf2 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant