🔒 Fix missing Network capability check in std.dns - #82
Tcode-Motion wants to merge 2 commits into
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Added a missing capability check for
Capability::Networkinstdlib/src/dns.rswithin thelookupfunction. Also updatedrequired_capabilitiesin theregister_modulecall to accurately reflect this requirement.Without this check, the system allowed any code, regardless of granted capabilities, to perform network DNS lookups. This could be exploited to bypass network restrictions, leak internal network structures, or act as a stepping stone for DNS-based attacks.
🛡️ Solution:
Replaced
_ctxwithctxto evaluate capability configuration in the callback and inserted a conditional check that returns aRuntimeError(InvalidOperation) ifctx.config.capabilities.contains(&Capability::Network)evaluates to false. Validated the fix via a new deterministic integration test targeting restricted runtime environments.PR created automatically by Jules for task 15487683922587520007 started by @Tcode-Motion