Skip to content

🔒 Fix missing Network capability check in std.dns - #82

Closed
Tcode-Motion wants to merge 2 commits into
mainfrom
fix-dns-capability-check-15487683922587520007
Closed

Tcode-Motion wants to merge 2 commits into
mainfrom
fix-dns-capability-check-15487683922587520007

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What:
Added a missing capability check for Capability::Network in stdlib/src/dns.rs within the lookup function. Also updated required_capabilities in the register_module call to accurately reflect this requirement.

⚠️ Risk:
Without this check, the system allowed any code, regardless of granted capabilities, to perform network DNS lookups. This could be exploited to bypass network restrictions, leak internal network structures, or act as a stepping stone for DNS-based attacks.

🛡️ Solution:
Replaced _ctx with ctx to evaluate capability configuration in the callback and inserted a conditional check that returns a RuntimeError (InvalidOperation) if ctx.config.capabilities.contains(&Capability::Network) evaluates to false. Validated the fix via a new deterministic integration test targeting restricted runtime environments.


PR created automatically by Jules for task 15487683922587520007 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant