Repository navigation
fix(pull): make role-less skill delivery deterministic - #1583
Closed
huong8373tt-beep wants to merge 1 commit into
Closed
huong8373tt-beep wants to merge 1 commit into
huong8373tt-beep wants to merge 1 commit into
Conversation
huong8373tt-beep
marked this pull request as ready for review
October 30, 2026 10:49
|
No findings in the specified diff. The PR description satisfies the testing requirement: it records a build and a representative real-CLI run confirming shared-skill selection and the namespace skip notice. Review was read-only; I did not run, build, or install PR code. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial implementation of #1577's same-name skill delivery fix.
skills/<name>/copy over a same-name namespace copy, because namespaces are opt-in through roles and projects.Validation
npx vitest run src/__tests__/desired-skills.test.ts— 7 passednpm run typechecknpm run lintnpm run buildgit diff --checkskills/release/andskills/dev/release/, a role-lessteamai pull --forceinstalled the shared skill and printed the skip notice forskills/dev/release.The remaining delivery-record cleanup/lint work described in #1577 is intentionally outside this focused change.
Disclosure and authorization
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.