Skip to content

fix(pull): make role-less skill delivery deterministic - #1583

Closed
huong8373tt-beep wants to merge 1 commit into
Tencent:mainfrom
huong8373tt-beep:fix/deterministic-skill-delivery-1577
Closed

huong8373tt-beep wants to merge 1 commit into
Tencent:mainfrom
huong8373tt-beep:fix/deterministic-skill-delivery-1577

Conversation

@huong8373tt-beep

Copy link
Copy Markdown
Contributor

Summary

Partial implementation of #1577's same-name skill delivery fix.

  • Make role-less skill selection deterministic instead of depending on filesystem enumeration order.
  • Prefer the shared skills/<name>/ copy over a same-name namespace copy, because namespaces are opt-in through roles and projects.
  • Report each skipped namespace copy and how the member can select it.
  • Keep role- and project-scoped selection unchanged.
  • Document the rule in English and Chinese distribution guides.

Validation

  • npx vitest run src/__tests__/desired-skills.test.ts — 7 passed
  • npm run typecheck
  • npm run lint
  • npm run build
  • git diff --check
  • Built-CLI verification: with both skills/release/ and skills/dev/release/, a role-less teamai pull --force installed the shared skill and printed the skip notice for skills/dev/release.

The remaining delivery-record cleanup/lint work described in #1577 is intentionally outside this focused change.

Disclosure and authorization

Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.

@huong8373tt-beep
huong8373tt-beep marked this pull request as ready for review October 30, 2026 10:49
@github-actions

Copy link
Copy Markdown

No findings in the specified diff.

The PR description satisfies the testing requirement: it records a build and a representative real-CLI run confirming shared-skill selection and the namespace skip notice.

Review was read-only; I did not run, build, or install PR code.

@SaulMoro

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Thank you for working on #1577. #1584 landed the same fix together with the second half of the issue (removeDelivered and its lint rule) in 254fb92, so I'm closing this one as superseded.

@SaulMoro SaulMoro closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants