fix(mcp): use spec-accurate read-only annotations - #335
Merged
Conversation
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dodeja
marked this pull request as ready for review
August 21, 2026 05:15
SummaryReviewed the MCP tool annotation changes that mark nine fetch/list/search operations as read-only while keeping Verdict✅ Reviewed — no issues found. The annotations accurately reflect the tools' behavior, with no actionable bugs, security concerns, breaking changes, or concurrency issues identified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readOnlyHint: truetrack_containernon-read-only, non-destructive, private-account-only, and non-idempotentRationale
The Claude directory validates MCP tool annotations according to the protocol. Emitting redacted operational logs does not make a fetch-only tool a write, so the prior all-false annotation set was inaccurate.
Testing
npm run test --workspace @terminal49/mcp -- --run(182 tests)npm run build --workspace @terminal49/mcpNODE_OPTIONS=--experimental-strip-types npm run lint --workspace @terminal49/mcpchatgpt-app-submission.jsonwith Node.js JSON parserNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
This PR corrects MCP metadata so nine fetch-only tools are declared read-only while
track_containerremains the sole write operation.Confidence Score: 5/5
The PR appears safe to merge because the reclassified tools only execute read operations and the sole account-mutating tool remains explicitly non-read-only.
Runtime registration, protocol coverage, submission metadata, and actual handler behavior consistently preserve the boundary between nine fetch-only tools and
track_container.Important Files Changed
track_containeras a non-read-only write operation.track_container.Reviews (1): Last reviewed commit: "fix(mcp): correct read-only tool annotat..." | Re-trigger Greptile