Skip to content

Update ChatGPT store listing container fixtures - #341

Merged
dodeja merged 1 commit into
mainfrom
cursor/update-chatgpt-fixtures-881f
Aug 21, 2026
Merged

Update ChatGPT store listing container fixtures#341
dodeja merged 1 commit into
mainfrom
cursor/update-chatgpt-fixtures-881f

Conversation

@dodeja

@dodeja dodeja commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the synthetic ChatGPT search fixture with TGBU8848518 / COSU
  • update the tracking fixture and expected outputs without changing other test cases

Verification

  • parsed chatgpt-app-submission.json successfully
  • confirmed cases 1 and 5 retain search_container and track_container
  • confirmed the branch changes only the requested four JSON strings in one file
  • confirmed claude-connector-submission.json is unchanged and contains no old fixture
Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Greptile Summary

This PR updates the ChatGPT app-directory submission cases to use TGBU8848518 with carrier COSU.

  • Replaces the synthetic search prompt and expected response.
  • Updates the tracking prompt and expected response for the same container.

Confidence Score: 4/5

The PR appears safe to merge, but the tracking fixture should be constrained to a known pre-tracked container so directory verification cannot mutate the connected account.

The changed prompt can reach track_container's persistent creation path when TGBU8848518 is absent, making repeated submission tests state-dependent.

Files Needing Attention: chatgpt-app-submission.json

Important Files Changed

Filename Overview
chatgpt-app-submission.json Updates four submission-fixture strings; the new tracking case should be constrained to a known pre-tracked test account to avoid persistent side effects.

Fix all with Greploop Fix All in Codex Fix All in Claude Code

Prompt To Fix All With AI
### Issue 1
chatgpt-app-submission.json:167-169
**Uncontrolled tracking fixture mutation**

If the connected test account does not already track TGBU8848518, this case invokes `track_container`'s persistent creation path, adding a real tracking request and making subsequent verification runs exercise a different state. Use a controlled, pre-tracked fixture so the directory test remains repeatable and does not mutate the account.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore: update ChatGPT listing container ..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api Ready Ready Preview Aug 21, 2026 10:41pm

Request Review

@dodeja
dodeja marked this pull request as ready for review August 21, 2026 22:43
@dodeja
dodeja merged commit 68be0db into main Aug 21, 2026
23 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96954d8a6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{
"description": "Find a tracked container by container number.",
"user_prompt": "Find the synthetic review fixture container CAIU1234567 in my Terminal49 account and summarize its current status.",
"user_prompt": "Find TGBU8848518 in my connected Terminal49 account and summarize its current status.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a synthetic container placeholder

This replaces the explicitly synthetic fixture with a valid container identifier and associates it with a connected Terminal49 account and COSU; because this submission file is public, it exposes account-linked shipment information rather than using a placeholder. Replace both occurrences with synthetic fixture data that cannot identify a real shipment.

AGENTS.md reference: AGENTS.md:L1-L3

Useful? React with 👍 / 👎.

Comment on lines +167 to 169
"user_prompt": "Track TGBU8848518 with carrier SCAC COSU in my Terminal49 account.",
"file_attachment_urls": null,
"tools_triggered": "track_container",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Uncontrolled tracking fixture mutation

If the connected test account does not already track TGBU8848518, this case invokes track_container's persistent creation path, adding a real tracking request and making subsequent verification runs exercise a different state. Use a controlled, pre-tracked fixture so the directory test remains repeatable and does not mutate the account.

Prompt To Fix With AI
This is a comment left during a code review.
Path: chatgpt-app-submission.json
Line: 167-169

Comment:
**Uncontrolled tracking fixture mutation**

If the connected test account does not already track TGBU8848518, this case invokes `track_container`'s persistent creation path, adding a real tracking request and making subsequent verification runs exercise a different state. Use a controlled, pre-tracked fixture so the directory test remains repeatable and does not mutate the account.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Claude Code

@vorflux vorflux Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Reviewed — found 1 issue. This change replaces synthetic ChatGPT listing fixtures with a valid container/carrier pair; I reviewed the updated prompts and expected outputs for repeatability and side effects.

Findings

chatgpt-app-submission.json

  1. The valid track_container fixture can create additional persistent tracking requests when directory verification is rerun before the container links.

Verdict

⚠️ Changes requested. The mutating fixture should use controlled, resettable test data so repeated review runs do not alter account state unpredictably.


Review with Vorflux

{
"description": "Create a tracking request for a container that is not already tracked.",
"user_prompt": "Track the synthetic review fixture container CAIU1234567 with carrier SCAC MAEU in my Terminal49 account.",
"user_prompt": "Track TGBU8848518 with carrier SCAC COSU in my Terminal49 account.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now invokes the mutating track_container tool with a valid container/carrier pair. Per docs/mcp/home.mdx, when the container is not yet linked, repeated calls can create additional tracking requests; a read-only search using the configured review account also returned zero matches for TGBU8848518. That makes repeated directory verification stateful and potentially non-repeatable. Please use a controlled container guaranteed to be pre-tracked in the reviewer account, or a dedicated resettable fixture/account.

@vorflux

vorflux Bot commented Aug 21, 2026

Copy link
Copy Markdown

Testing

Ran an authenticated, read-only Terminal49 API search for TGBU8848518 to determine whether the configured review account already contained the proposed fixture. The request succeeded but returned no results. This evidence applies only to the configured account, not OpenAI’s separate reviewer account.

Commands run:

status=$(curl --silent --show-error \
  --output /tmp/t49-pr341-search.json \
  --write-out '%{http_code}' \
  -H "Authorization: Token $T49_API_KEY" \
  'https://api.terminal49.com/v2/search?query=TGBU8848518')

python - <<'PY'
import json, collections
p = '/tmp/t49-pr341-search.json'
d = json.load(open(p))
rows = d.get('data') or []
print({
    'http_success': True,
    'result_count': len(rows),
    'types': dict(collections.Counter(str(r.get('type')) for r in rows)),
})
PY

rm -f /tmp/t49-pr341-search.json

Result:

HTTP 200
{'http_success': True, 'result_count': 0, 'types': {}}

Verdict

⚠️ Issues found. The proposed valid fixture is not established as pre-tracked, so rerunning the mutating test can create additional persistent requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants