Update ChatGPT store listing container fixtures - #341
Conversation
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96954d8a6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "description": "Find a tracked container by container number.", | ||
| "user_prompt": "Find the synthetic review fixture container CAIU1234567 in my Terminal49 account and summarize its current status.", | ||
| "user_prompt": "Find TGBU8848518 in my connected Terminal49 account and summarize its current status.", |
There was a problem hiding this comment.
Restore a synthetic container placeholder
This replaces the explicitly synthetic fixture with a valid container identifier and associates it with a connected Terminal49 account and COSU; because this submission file is public, it exposes account-linked shipment information rather than using a placeholder. Replace both occurrences with synthetic fixture data that cannot identify a real shipment.
AGENTS.md reference: AGENTS.md:L1-L3
Useful? React with 👍 / 👎.
| "user_prompt": "Track TGBU8848518 with carrier SCAC COSU in my Terminal49 account.", | ||
| "file_attachment_urls": null, | ||
| "tools_triggered": "track_container", |
There was a problem hiding this comment.
Uncontrolled tracking fixture mutation
If the connected test account does not already track TGBU8848518, this case invokes track_container's persistent creation path, adding a real tracking request and making subsequent verification runs exercise a different state. Use a controlled, pre-tracked fixture so the directory test remains repeatable and does not mutate the account.
Prompt To Fix With AI
This is a comment left during a code review.
Path: chatgpt-app-submission.json
Line: 167-169
Comment:
**Uncontrolled tracking fixture mutation**
If the connected test account does not already track TGBU8848518, this case invokes `track_container`'s persistent creation path, adding a real tracking request and making subsequent verification runs exercise a different state. Use a controlled, pre-tracked fixture so the directory test remains repeatable and does not mutate the account.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Summary
Reviewed — found 1 issue. This change replaces synthetic ChatGPT listing fixtures with a valid container/carrier pair; I reviewed the updated prompts and expected outputs for repeatability and side effects.
Findings
chatgpt-app-submission.json
- The valid
track_containerfixture can create additional persistent tracking requests when directory verification is rerun before the container links.
Verdict
| { | ||
| "description": "Create a tracking request for a container that is not already tracked.", | ||
| "user_prompt": "Track the synthetic review fixture container CAIU1234567 with carrier SCAC MAEU in my Terminal49 account.", | ||
| "user_prompt": "Track TGBU8848518 with carrier SCAC COSU in my Terminal49 account.", |
There was a problem hiding this comment.
This now invokes the mutating track_container tool with a valid container/carrier pair. Per docs/mcp/home.mdx, when the container is not yet linked, repeated calls can create additional tracking requests; a read-only search using the configured review account also returned zero matches for TGBU8848518. That makes repeated directory verification stateful and potentially non-repeatable. Please use a controlled container guaranteed to be pre-tracked in the reviewer account, or a dedicated resettable fixture/account.
TestingRan an authenticated, read-only Terminal49 API search for Commands run: status=$(curl --silent --show-error \
--output /tmp/t49-pr341-search.json \
--write-out '%{http_code}' \
-H "Authorization: Token $T49_API_KEY" \
'https://api.terminal49.com/v2/search?query=TGBU8848518')
python - <<'PY'
import json, collections
p = '/tmp/t49-pr341-search.json'
d = json.load(open(p))
rows = d.get('data') or []
print({
'http_success': True,
'result_count': len(rows),
'types': dict(collections.Counter(str(r.get('type')) for r in rows)),
})
PY
rm -f /tmp/t49-pr341-search.jsonResult: Verdict |
Summary
Verification
chatgpt-app-submission.jsonsuccessfullysearch_containerandtrack_containerclaude-connector-submission.jsonis unchanged and contains no old fixtureNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
This PR updates the ChatGPT app-directory submission cases to use TGBU8848518 with carrier COSU.
Confidence Score: 4/5
The PR appears safe to merge, but the tracking fixture should be constrained to a known pre-tracked container so directory verification cannot mutate the connected account.
The changed prompt can reach track_container's persistent creation path when TGBU8848518 is absent, making repeated submission tests state-dependent.
Files Needing Attention: chatgpt-app-submission.json
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: update ChatGPT listing container ..." | Re-trigger Greptile