Repository navigation
Add Bluetooth open_rear_trunk and close_rear_trunk - #191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two Bluetooth-only vehicle commands on
VehicleBluetooth:open_rear_trunk()sends a VCSECClosureMoveRequestwithrearTrunk=CLOSURE_MOVE_TYPE_OPEN.close_rear_trunk()sends a VCSECClosureMoveRequestwithrearTrunk=CLOSURE_MOVE_TYPE_CLOSE.They follow the existing individual-door commands (
open_front_driver_door()and the others). The existingactuate_trunk(Trunk.REAR)sendsCLOSURE_MOVE_TYPE_MOVE, which toggles the trunk; these new commands give a result that does not depend on the current trunk state. Home Assistant fork PR Teslemetry/home-assistant#62 needs them.Tests
tests/test_ble_mocked_closures_locks.py: the per-field closure test now covers both commands. It checks that each one sets onlyrearTrunkwith the expected move type on the VCSEC domain.pyright tesla_fleet_api: 0 errors.ruff check: clean.No commands were sent to a real vehicle.
Docs
docs/bluetooth_vehicles.mdgets a short "Open/Close Rear Trunk" section.