Repository navigation
AGENTS.md: correct buf breaking and upstream PR pin entries, add .venv rule - #85
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises AGENTS.md against the last month of agent sessions in this repository (14 sessions since 2026-10-03) and the current state of main. It changes no code.
Correction,
buf breakingentry under "Proto content rules": the old entry said a renumber is never possible and that the only sanctioned fix is to reserve the old name and add a new field. Seven sessions shipped or prepared approved breaking corrections another way, with a temporarybreaking.ignore_onlyblock inbuf.yaml(#68 added one forcommon_api.proto, #70 deleted it after 4.0.0, #75 replaced the 4.0.1 telemetry block with one for threecommandfiles, and the field 272-278 resync, the 5.0.0 follow-up and the 6.0.0 full pass each built or merged one). One more session stopped for a decision because nothing told it this path existed, and a review on #75 objected that abuf.yamlchange loosened checks beyond the approved renames. The entry now describes the mechanism: a maintainer decision first, then a block that names only the rules that fired and the files they fired on, merged with any existing block and deleted in the first PR after the release. The reserve-and-rename option and theNavigationSuperchargerRequestexample stay, becausecar_server.protopoints to them.Correction, upstream PR pin under "Upstream sync": the old entry limited pinning to a PR on a branch the upstream org owns, not a fork. Two sessions found the upstream PRs they had to pin come from a fork (fleet-telemetry #572 and #582), pinned them anyway, and the pinned gate passed, because the upstream repo's raw URL serves the fork's head commit. main pins #582's fork head today. The entry now says forks work. It also adds one clause about the weekly
upstream-drift.ymlPR, which moves a PR-head pin back to upstream main and drops that PR's symbols. One session was told to fix that PR (#65) on its bot branch before it found that every run force-pushesupstream-reconcile, and the same bot PR is open again now (#69).Addition,
.venvrule under "Generated code": four sessions ranscripts/build_catalog.py,scripts/upstream_coverage.pyor a Python check with systempython3, or before.venvexisted, and hitModuleNotFoundError: No module named 'google'. One of them reported the coverage gate as impossible to run, and one built a separate virtualenv. One session also hitbuf: command not found. The new line says to use.venv/bin/python, thatpnpm install && pnpm generatecreates it, and to run buf throughpnpm exec.Correction, gencode stamp entry: it said a pin bump rewrites "all 38
_pb2.pyfiles"; there are 44 now, so the text says "every_pb2.pyfile".Removal, the
publish.ymlbullet under "Release": it restated README "Releases", which already explains thatpublish.ymlreusesci.ymland that both publish jobs wait on it. No session touched the release path. The pointer to README for publish flow and interrupted-publish recovery stays in one shorter line.Not changed here, because it is code: the temporary
ignore_onlyblock inbuf.yamland the matching--against-config buf.yamlflag inci.ymlboth say to delete them in the first PR after 6.0.0 is published, and 6.2.0 is now out.