Reject incomplete metric records during decode - #76
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 790e9d94f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "block": "MODULE_BUILD", |
There was a problem hiding this comment.
When the canonical metadata CI job runs, this deletion makes the tracked collection stale: .github/workflows/skill-compliance.yml invokes the pinned msdmd/collect.py --root edcm and then diffs its output against this file, while .agents/skills/interdependent-work-graph/portfolio_plan.py still contains the corresponding MODULE_BUILD block. Replaying that collection command restores this declaration and its owns edge, so the comparison will fail on every build until both entries remain in the generated collection.
Useful? React with 👍 / 👎.
1 participant
Closes the missing-metrics-to-zero decoder defect. Incomplete metric objects now fail before RoundMetrics defaults can turn absence into zero. Adds a rejecting regression witness that was red before the repair.\n\nValidation:\n- full suite: 308 passed, 29 skipped\n- metadata contracts: passed\n- EDCM integrity: passed\n\nNo evidence was regenerated through the repaired decoder. Package build was not locally completed because the existing EDCM virtualenv lacks setuptools and wheel; remote CI remains the packaging authority for this PR.