Skip to content

docs(attribution): align data-visualization license summaries (stacked on #112) - #113

Open
erinepshovel-code wants to merge 3 commits into
mainfrom
repair/data-visualization-attribution-followup
Open

erinepshovel-code wants to merge 3 commits into
mainfrom
repair/data-visualization-attribution-followup

Conversation

@erinepshovel-code

Copy link
Copy Markdown
Contributor

Stacked on #112. Base is repair/data-visualization-attribution (#112 head 8f23c5e). Merge #112 first, then this PR. After #112 merges, retarget this PR to main if GitHub doesn't do it automatically.

Summary

This PR addresses the review findings on #112 without pushing to #112, so its approval stays in place.

  • Finding 1 (P2), directory-level summaries. The README.md, CLAUDE.md and ORG_DISTRIBUTION.md rows and the ## Provenance section of data-visualization/SKILL.md now match ATTRIBUTION.md:
    • Only SKILL.md is imported from anthropics/knowledge-work-plugins@94e1a08.
    • The whole SKILL.md, including its local additions, is Apache-2.0.
    • The four information-design extension files from skill-lib 868de86 are original to skill-lib under MPL-2.0.
  • Finding 2, licence of the local additions in SKILL.md. This was settled by the License agent's decision, not left as hmmm: the local additions are Apache-2.0.
    • The SKILL.md Provenance section gains the License-provided sentence, verbatim. It says the locally added sections (## Workflow, ## Anti-patterns, ## The Interdependency information-design extension and its subsections, and ## Provenance) are contributed under Apache-2.0, so the whole file is available under Apache-2.0. I confirmed that all of the named headings exist in the file.
    • ATTRIBUTION.md gains the matching License-provided sentence, verbatim.
  • Finding 3 (P3). The Provenance change notice now also says the Cowork-only user-invocable frontmatter key was removed.
  • Finding 4 (P3). ATTRIBUTION.md lists the four local files individually instead of the examples/ and references/ folders.
  • Finding 5 (P3). The awkward sentence in ATTRIBUTION.md is tightened with the same meaning: "data-visualization/SKILL.md also has a clearly marked information-design extension appended locally (skill-lib 868de86)."
  • skill-lib_msdmd.ts. Regenerated with python -m msdmd.collect … --strict because hashed files changed. The diff is the new snapshot hash plus new content hashes and sizes for ATTRIBUTION.md, CLAUDE.md, ORG_DISTRIBUTION.md, README.md and data-visualization/SKILL.md.

No licence headers or other files changed.

Verification

  • Native collection --check and tsc --noEmit --strict: pass
  • python -m unittest discover -s tests: 377 passed (Python 3.13, pinned msdmd/requirements.txt, Node 24.15.0)
  • drift and compliance --warnings-fail, codex adapters --check, llms.build --check, RATIOS --strict, gonol authority, RepoLOTO audit and checks, no tracked bytecode, git diff --check: all pass

hmmm

Upstream anthropics/knowledge-work-plugins@94e1a08 ships only
data/skills/data-visualization/SKILL.md. The examples/, references/,
information_design_audit.py, and visual-grammar.json files were added
locally in skill-lib 868de86 and are original MPL-2.0 content. Records
the appended information-design extension as a local modification of
the imported SKILL.md.

Regenerates skill-lib_msdmd.ts with msdmd.collect because the snapshot
identity binds ATTRIBUTION.md content (collection --check requires it).

Flagged in The-Interdependency/stack#60.
Follow-up to #112 review:
- README, CLAUDE.md, ORG_DISTRIBUTION.md, and the SKILL.md Provenance
  now say only SKILL.md is imported (anthropics/knowledge-work-plugins
  @94e1a08); the whole SKILL.md, including local additions, is
  Apache-2.0; the four extension files from 868de86 are MPL-2.0.
- Provenance notes removal of the Cowork-only user-invocable key.
- ATTRIBUTION.md lists the four local files individually, tightens the
  extension sentence, and records the License decision that local
  additions to SKILL.md are contributed under Apache-2.0.
- Regenerates skill-lib_msdmd.ts for the changed hashed files.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T23:43:13.901610Z 0da848f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@erinepshovel-code
erinepshovel-code changed the base branch from repair/data-visualization-attribution to main September 28, 2026 23:39
…tion-attribution-followup

# Conflicts:
#	ATTRIBUTION.md
#	skill-lib_msdmd.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant