Repository navigation
Retire URPCS after specification divergence - #61
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b40c80fce4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Retire remaining authority projections, preserve unknown intended-design provenance, and verify sealed historical source bytes separately from current retirement metadata.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7be7ca5b49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "authority": "stack-local URPCS codec research", | |||
| "authority": "retired historical evidence for substituted URPCS codec implementation; not authority for Erin Spencer's intended URPCS specification", | |||
There was a problem hiding this comment.
Mark the BASE standing as historical
Although this updates BASE.authority to retired historical evidence, the same machine record still exports standing: "stack-local-research" on line 7. Consumers that classify workspaces from BASE.json will therefore continue treating URPCS as active research despite the retirement, and the consistency checker currently does not catch that contradiction. Change the standing to a historical/retired value and include it in the retirement consistency checks.
AGENTS.md reference: AGENTS.md:L22-L25
Useful? React with 👍 / 👎.
| if path in {"research/urpcs/WORK_GRAPH.json", "research/urpcs/SOURCE_RECEIPT.json"}: | ||
| data = subprocess.check_output(["git", "-C", str(STACK_ROOT), "show", | ||
| f"{analyzer.STACK_INPUT_COMMIT}:{path}"]) |
There was a problem hiding this comment.
Load historical metadata in the analyzer itself
The new test reads historical copies of WORK_GRAPH.json and SOURCE_RECEIPT.json, but the documented relational-audit CLI still calls _authority_context(), which compares every current FROZEN_PATHS file byte-for-byte with STACK_INPUT_COMMIT at urpcs_relational_analyzer.py:912-914. Because this commit changes both metadata files, running the README's audit command with otherwise exact UCNS, skill-lib, and METAPAT checkouts now always raises frozen URPCS drift; apply the historical-file handling to the executable validation path as well, or stop treating the mutable retirement projections as frozen computational inputs.
Useful? React with 👍 / 👎.
| if path == "research/urpcs/tests/test_relational_analyzer.py": | ||
| # Exact pre-repair test source recorded by the sealed receipt. | ||
| data = subprocess.check_output(["git", "-C", str(STACK_ROOT), "show", | ||
| f"01f340ba5b4c5f107703233750768e201a41da68:{path}"]) |
There was a problem hiding this comment.
Keep the historical-evidence tests shallow-clone safe
In a depth-1 checkout, this new git show exits 128 because commit 01f340b... is outside the shallow history; the analogous lookup of STACK_INPUT_COMMIT at lines 271-273 fails as well. Consequently the README's unittest discover command now reports two errors in ordinary shallow clones, even though this test was previously able to verify the receipt from checked-out bytes. The updated project workflow hides the regression with fetch-depth: 0, but other CI and local shallow callers still break, so verify against stored receipt identities without requiring unreachable commits or explicitly deepen the repository before these checks.
Useful? React with 👍 / 👎.
Retires
research/urpcs/as historical evidence after conversation-history review established that the GPT-assisted implementation substituted a recursive pairing/authenticated codec for Erin Spencer's intended multi-arity interleaving construction.The retained code/tests/receipts remain evidence only for the substituted implementation. They must not be used to validate or falsify the intended URPCS design.
Updates the local warning, root architecture projections, agent guidance, BASE authority, machine work graph, human manifest, and recomputed work-graph digest. Cause of the substitution remains
hmmm.