Repository navigation
Extract English structural profile candidate with full replay proof - #9
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ad97a3c06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Integrates current main and exact Stack source 0e8f59c7b9afdd0c3e9a173841b1bcc4f58dcac2. Complete corpus and clean candidate replay pass. Extraction does not confer release or graduation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ac398c059
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tity Exact source bf3c8816ce4fc64ad26aaf61488aeb22a91e3351. Two complete source/clean-wheel builds are byte-identical; 67 structural and 86 clean-installed tests pass. Preserve historical a1 consumer locks and pending a2 integration/release/graduation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e429529b4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cb32d1dc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ee73b7211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 927d6c2d85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nd SQLite sidecars, document corpus-build extra
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b02760e01c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… database, null partial source commit, complete_corpus, POSIX build note
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c18d984438
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _verified_connection(out_dir: str | Path): | ||
| """Keep verification and subsequent reads on one snapshot until closed.""" | ||
| root = Path(out_dir) | ||
| manifest_bytes = (root / "manifest.json").read_bytes() |
There was a problem hiding this comment.
When verifying an artifact supplied by another process, this unconditionally follows manifest.json symlinks and can block indefinitely on a FIFO; replacing a generated manifest with a symlink to the same bytes outside the artifact still lets verify() pass. The supposedly sealed directory therefore need not contain the receipt it verifies and may break or change when copied or distributed. Require a bounded, nonsymlink regular manifest file before reading it, as is already done for construct.db.
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
1 participant
Extract the accepted structural profile from Stack's forge implementation: The-Interdependency/stack#81. Extraction source commit: b7e4f50bdeaf23ccd04a446ab3ac59e373fb57da, the last implementation commit on #81. #81's final head, 9033c9f627f5ec1096d21fb87b0c69a749d33c8e, adds only evidence and a separate candidate receipt pinning this PR's head and wheel, so it cannot itself be the extraction source without a pin cycle; its implementation files are byte-identical to b7e4f50.
This separates punctuation/whitespace from word identity, preserves exact ordered references to shared glyph/word identities, implements atomic word promotion and explicit ambiguous closure, and admits queries only against the complete pinned OEWN field. Definition records, provenance and origin/topology boundaries remain recoverable. Unsupported geometry emits named refusals.
Every implementation-digest module (
IMPLEMENTATION_FILES) and the structural tests match the forge byte-for-byte. The extraction receipt binds those hashes and the published source commit. Candidate package version is 0.1.0a2; historical 0.1.0a1 locks and sealed v2 evidence retain their original scope. Stack remains the forge until graduation.Validation: 291 English tests plus 5 Python-domain and 5 polyglot tests passed; 161 structural tests (180 total) also passed from a clean-installed 0.1.0a2 wheel. Two complete builds (installed development wheel using the same implementation digest and Stack source) produced byte-identical databases and manifests. All 185,155 definitions are preserved; the new field has 103,053 shared word identities. Added complete-corpus replay CI and included structural tests in clean-install CI.
Evidence: human/english/experiments/structural-profile-v1/{manifest,verification,extraction,query}.json. Native module projection covers 4 modules with zero attachment findings and 4 verified ratio seals.
hmmm: 57,155 compound/punctuated lexical definitions require an authorized word-origin attachment. UCNS geometry, stable release, downstream migration and graduation remain incomplete. Parser conventions are explicit candidate choices.