Repository navigation
W120 — One Campaign Can Include Another - #568
Merged
Merged
Conversation
Builds the campaign composition contracted in #561: the core checks includes, pins, cycles, aliases and attachment hosts (seven codes) and composes depth-first, each campaign once; story-graph merges modules under alias:: ids through Kind.composeContent (six codes), with entry and exit as synthesized auto nodes and bindings carried by the new copy consequence. Pack attachments append one choice to a host node after the fold, and a pack's digest moves only when it carries includes or attachments, so every committed campaignVersion is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Builds W120: campaign composition as contracted in #561 (04 §10.4, 11 §3a, 03 §1.1, §5, §8.3).
core/registry/compose.ts): checks includes, authored-version pins, kind match, cycles, aliases and attachment hosts, using seven codes. It composes depth-first, each campaign once, and hands modules and attachments toKind.composeContent. BothbuildValidatedContentRegistryandbuildValidatedPackRegistrycompose before validation runs.resolvePacksreturnsauthoredVersionsandattachments. A pack's digest gainsincludesandattachmentsonly when they are non-empty.kinds/story-graph/compose.ts):alias::ids;autoentry and exit nodes;copyconsequence;copyand for composed ids.Criteria
/authoring.core/registry/compose.test.ts.kinds/story-graph/compose.test.ts.:id is stillinvalid_identifier(node, var, achievement, alias, composed-shaped host id).copyreadsfromas the batch left it, and clamps once. Tier 1 rejects an undeclaredfrom, a type mismatch, a non-subset enum and an undeclaredvar.turneach;visited.<alias>counts entries;Differs from design
get-next-slice.tsreports the plan "Finished" because it parses only## S<n>headings. This ledger uses### [ ] W<n>, so W120 was picked by hand.90-decisions.md, 2026-10-07 — W120: composition is built as contracted. These are:composeContent.20-contract.md§12's note that composition's codes "are not inreasons.tsuntil W120" is updated.Verified
npm run typecheck,npm run lint: clean.npm test: 112 files, 2104 tests passed.isAssignable;interpolationScope;./build/Test-Documentation.ps1: drift check passed (18 pages plus the guide), 131 Markdown files.git diff --check: clean../docs.ps1 -BuildOnly. Rely on the Verify Documentation Build check.test-design.tsreports 49 findings, all pre-existing path-fragment false positives (/authoring,/contract); none were introduced here.