Repository navigation
ci: build docs with the shared docs workflow - #585
Merged
Merged
Conversation
…a does not depend on the fallback font
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the repository's own
docs-ci.ymlanddocs-deploy.ymlwith the shareddocs.ymlworkflow from GitHub-ActionTemplates (@v0). It builds in the build-agent image, runs on pull requests and on pushes to main, and deploys to GitHub Pages from main only. Repository-specific steps stay in this repository as scripts, passed to the workflow by path.Depends on GitHub-ActionTemplates#7, released as v0.3.0.
Required check:
docs / Buildreplaces the old docs checks in branch protection and rulesets; the deploy job isdocs / Deploy.Steps
changelog: docs/docs/engine/CHANGELOG.mdwithslug: changelogfront matter, generated by the sharedchangelogaction.build/ConvertTo-Changelog.ps1is removed and RELEASE.md §5 updated.pre-build:./build/Test-Documentation.ps1node-project: site, scriptscheck merge, after buildingsrc/engine, withbrowser: true(system Chromium).output: artifacts/docsAlso
Comments in
ci.yml,host-image.ymland the Dockerfile,agent.mdandsrc/host/README.mdname the new workflow.Site fix
The header nav links had
line-height: normal, so their height came from the fallback font's metrics: 15px with DejaVu Sans on Debian and Ubuntu, under the 16px hit-area floor the browser tests assert (Alpine's Open Sans fallback had hidden it).site/src/site.cssgives themline-height: 1.5, about 19.7px in any font.Testing
Built in the build-agent 2.0.0-28 container: changelog (510 entries), pre-build, the docs build and the site's
check merge(23/23 browser tests) pass.