Skip to content

requests 型 429(50/窗口,Remaining 0)成片打掉 Bot 轮次,审查与实现两头阻塞 #1308

Closed

Description

@Birfy

事实

provider 回的 429 原文(requests 型,单 key):

Rate limit exceeded for api_key: 4a14c40e…fd02ad7. Limit type: requests. Current limit: 50, Remaining: 0.
  • 打掉的是单 key 的请求数(50/窗口,Remaining: 0),不是预算。
  • reset 字段被截断,因此不推断恢复时刻。
  • 与 budget_exceeded 500.02 / 500.0(Key=00885737)是两套限制,不要混写:那条是花费超预算,这条是请求数窗口打满。

时间线(UTC,2026-10-27)

时刻 被打掉的
00:29Z 前 Dev2
00:30Z FlyBot 实现 Lead
00:52Z、01:06Z FlyBot 实现 Lead 两次答消息失败
~01:10Z FlyBot审查 Lead
01:1xZ Reviewer 两轮都没能判 #1289;Reviewer2 同时被打
~01:12Z Dev4
同期 Triage 对 #1305 的分诊也停在这上面

影响

  • #1289@5b832b91 的判定两轮被清空(PR 侧零新评论)。
  • #1305(main 自 00:55Z 起红的根因)的分诊与修复排队。
  • #1304@206fbadb 只差正文 Tip SHA / checks.at 更新,也做不了。

即:审查与实现两头同时阻塞,而两头的产出都被静默丢弃。

会反复出现

用户 00:56Z 曾答「已经恢复了」,之后又被打满 —— 说明它不是一次性事件,会反复出现。本单只做记录(按 Chief 的「成片 429 另开一条单记、别混进 #1306」),当前不推断恢复时刻(reset 被截断)。

Activity

  1. added
    bugSomething isn't working
    area:automationScheduled tasks and automation
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 27, 2026
  2. Birfy commented on Oct 27, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    Duplicate check: 0 duplicates among open issues. Two closed relatives, both different: #1044 (closed completed by #1124 — that one fixed the visibility of a turn that dies on a 429, not the request-count limit) and #1285 (closed — a stalled turn kept load: 1). This one is the single-key requests window at Limit 50 / Remaining 0.

    Labels: bug + area:automation (the visible surface is Bot turns being dropped) + needs-human.

    Reason for needs-human: turns stopped and are being dropped, so the loop cannot continue on its own, and what unblocks it is a person's call — raise or rotate the request window for the shared key, or accept a backoff policy. Per the body this issue only records the occurrences; nobody has chosen between those yet.

  3. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 29, 2026
  4. Birfy commented on Oct 29, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    Owner 决定:放行(用户 2026-10-29 拍板「全按建议走」)。

    范围:requests 型 429(provider 原文 Limit type: requests ... Current limit: 50, Remaining: 0)在模型调用路径上做退避重试;重试耗尽时把失败可见地报出来(一条明确的错误事件或系统提示),不再静默丢掉整个轮次。面积:core/src/host/ 的模型调用与错误处理路径,实现者定位到具体函数并在 PR 正文写行号。

    不做:不推断恢复时刻(原文 reset 被截断);不处理 budget_exceeded(那是另一套限制)。

    验收(红先):mock provider 连回 3 次 requests 型 429 后成功 → 轮次完成且日志有 3 次退避;一直 429 → 出现一条可见错误而不是空轮次;把退避改动换回 base 后这两条必须变红。

  5. removed
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 29, 2026
  6. Birfy commented on Oct 29, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    needs-human 已摘:上一条评论里的 owner 决定(2026-10-29,放行)解决了它当初的阻塞问题。现在的状态只有 agent-ready(bug + area:automation 保留)。

    范围就以 09:22Z 那条为唯一依据,本轮不再调研代码。

  7. self-assigned this
    on Oct 29, 2026
  8. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 29, 2026
  9. Birfy commented on Oct 29, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Dev
    Claimed #1308 — first step: the turn-level backoff in core/src/host/turns.js turn/end, branch dev/1308-rate-limit-retry.

  10. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 29, 2026
  11. Birfy commented on Oct 29, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Dev
    Tip 5e2e29d on dev/1308-rate-limit-retry → #1672. Red first: 2 new tests red with turns.js/delivery.js at their main blobs, 3/3 green at the tip.

  12. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 29, 2026
  13. added a commit that references this issue on Oct 29, 2026
    1d7c47b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:automationScheduled tasks and automationbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions