Skip to content

Project board: role-pool members read @id + rank, not a Dossier control #1892

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 7555f1be426f431ebece958f61430e5b
Branch: dev/1-p263-pool-no-dossier
Base: 76bdd2f
At: 2026-10-31T05:13:54Z

Current behaviour (live main 76bdd2fd)

core/src/client/project-board.js:615 (ProjectTeam) draws every role-pool member as a Dossier control:

  • poolId(id) (project-board.js:616-623) returns a <button class="bt-project-team-dossier" data-dossier-role="pool" data-dossier-bot="@bot-maint" aria-label="Open @bot-maint's dossier">, and its onClick calls onOpenDossier({ role: 'pool', label: 'Role pool', botId }).
  • The ranks line (POOL_RANKS, project-board.js:625-634) renders those buttons for owner / maintainer / member, so a pool entry looks and behaves like the Chief/agent dossier control.

#1864 designed the dossier for the Project's own Bots (Chief, my agent). The pool is a rank list, not a Bot the board holds a dossier answer for: project-team returns rows keyed by the Project's bots, so a pool click opens a dossier the host never answered.

Expected

  • Pool member entries render as plain text @id, keeping the rank label (Owner: / Maintainer: / Member:) and the caller's own-rank line (My role: …, Can switch to …).
  • No bt-project-team-dossier class, no data-dossier-role / data-dossier-bot on a pool entry, no Open …'s dossier aria-label, and no onOpenDossier call for a pool id.
  • Chief and my-agent rows keep their Dossier control unchanged.

Scope

  • core/src/client/project-board.js — ProjectTeam pool rendering only.
  • core/test/project-board-panels.test.js — one red-first test: the pool lists the stored ids and the caller's rank (existing assertions), and a pool entry carries no dossier control and never calls onOpenDossier; the Chief/agent rows still do.
  • changelog.d/<this-issue>-pool-no-dossier.changed.md (use this issue's number).
  • Not in scope: the dossier panel, Chief/agent rows, i18n copy for rows that keep a dossier, host-side project-team.

Dedupe

Checked live main and closed issues on 2026-10-31: #1864 (dossier on each Project Bot row) and #1883 (show each Project Bot's dossier on the board) are both closed; no open issue covers "pool rows should not draw a dossier". This is the follow-up Product triaged as P-263.

Notes

  • Base: 76bdd2fdafa7f0614b8cb175073f614584e74482.
  • Branch: dev/1-p263-pool-no-dossier.
  • Red first means the new assertion fails on 76bdd2fd (a pool entry currently has data-dossier-bot), not a snapshot diff.

Activity

  1. Birfy commented on Oct 31, 2026

    @Birfy
    Collaborator

    Triage: park — already implemented by open PR #1893 (dev/1-p263-pool-no-dossier, base 76bdd2fd); no pickup needed, no label.

  2. added
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 31, 2026
  3. Birfy commented on Oct 31, 2026

    @Birfy
    Collaborator

    Written-by: Triage

    park(H)— 卡在 promote 判据 3(非组间 / 不重复认领):本 issue 已被外部实现方认领,PR #1893 开着(HugoXK/FlyBot dev/1-p263-pool-no-dossier,tip 72e421eb,base 76bdd2fd,non-draft),正文写明 Do not pick up without a pickup-ok comment;此时打 agent-ready 只会让 Dev 重复认领同一改动。缺所有者的 pickup-ok / 归属裁定(接纳外部实现、由 Dev 认 owner 做 shepherd,或收回自改),谁能给:仓所有者(Birfy / Danyang)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions