Repository navigation
test(retired-bot-paths): wait for both reviews instead of fixed settles (#1833) - #1834
Merged
Merged
Conversation
…es (#1833) The #1786 assertion waited for m1's memory file, then two fixed settle() ticks, and read whatever requests had arrived. On a busy CI runner the second review (b3) landed after those ticks, so the assertion saw ['m1'] and failed. Wait for the deterministic condition instead: both reviews recorded and m1's memory written. The retired Bot (b2) must still stay out of requests. Docs-not-needed: test-only change to one timing assertion and its patch mirror.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Claim
Fixes #1833
Owner: Chief
Reviewer: Reviewer
Tip SHA: 1b1bd68
Base: 7d21690
Docs-not-needed: test-only change to one timing assertion and its patch mirror; no subsystem behaviour or docs page changes.
What changed
The #1786 assertion (
#1786: a retired Bot is not brought along by a lagging review, while a live member is) waited form1's memory file, then made two fixedsettle()calls, and read whateverrequestshad arrived. On a busy CI runner the second review (b3) lands after those ticks, so the assertion saw["m1"](#1832's redtests-ok, #1832, expected["b3","m1"]).It now waits for the deterministic condition: both reviews are recorded (
requests.length >= 2) andm1's memory file exists, then makes the same assertions. The fixedsettle()calls are gone. The semantic being protected is unchanged: a retired Bot (b2) must not appear inrequests.Files:
core/test/retired-bot-paths.test.jsand its whole-file mirrorpatches/ds-bot/files/test/retired-bot-paths.test.js(kept byte-identical).Ran (at 1b1bd68)
for i in $(seq 10); do node --test core/test/retired-bot-paths.test.js; done— 10/10 green, 22/22 tests each run.[]and fail (not ok 21); with only the fixed settles removed it still passed locally, which is exactly why the CI-only race needed a condition, not more ticks.node scripts/ds-bot-patches.mjs check—ok 10 patches apply cleanly in order,ok core/ equals ds-bot/ + patches/ds-bot/(pin check skipped:generateneedsgit, absent on this box; the mirror was updated by hand as that message instructs).Not run
npm run verify(full suite) — not run at this tip; only the one test file plus the patch check were run.tests-ok— not yet observed; it must be green at this tip before queueing.Checkpoint
{
"pr": 1834,
"claim": "Chief",
"issue": 1833,
"summary": "The #1786 retired-Bot review assertion no longer waits a fixed number of event-loop ticks. It waits until both reviews have been recorded (requests.length >= 2) and m1's memory file exists, then asserts the same set. The retired Bot b2 still must not appear. Ten consecutive local runs of the file are green; the same assertion goes red when the wait is removed.",
"files": [
"core/test/retired-bot-paths.test.js",
"patches/ds-bot/files/test/retired-bot-paths.test.js"
],
"checks": {
"ran": "for i in $(seq 10); do node --test core/test/retired-bot-paths.test.js; done && node scripts/ds-bot-patches.mjs check",
"result": "green",
"at": "1b1bd68e1be9d82f45a562cf518f263624cc1b95"
},
"next": "Wait for tests-ok at this tip, then Reviewer PASS before queueing."
}