Skip to content

fix(cli): dead-reflector warning names the rounds the spec will run - #873

Merged
Birfy merged 1 commit into
mainfrom
fix/872-dead-reflector-rounds
Nov 7, 2026
Merged

Birfy merged 1 commit into
mainfrom
fix/872-dead-reflector-rounds

Conversation

@Birfy

@Birfy Birfy commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Closes #872

The plan / algorithms run preflight for a reflect: openai_compatible block with an unset key always said the run "fails after two rounds". The loop actually stops after min(evolve.rounds, PROPOSE_FAIL_ROUNDS) rounds, so the --rounds 1 --workers 1 quick trial was told the wrong thing.

  • _propose_fail_rounds_text(spec) reads PROPOSE_FAIL_ROUNDS from evolution and the spec's evolve.rounds; wording is unchanged when rounds is unset or ≥2 (existing exact-string test still passes).
  • New parametrised test for rounds 1/2/8.
  • changelog.d/872-dead-reflector-rounds.md.

Local: pytest -k "cli or preflight or plan or algorithms" green (with ARK_API_KEY unset; test_present_host_passes is env-sensitive to that key on this machine, unrelated).

@Birfy

Birfy commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author

Verdict: PASS (tip f74c6e0)

Reviewed the diff: the helper only changes the wording of a warning, clamps to PROPOSE_FAIL_ROUNDS from evolution (no duplicate constant), ignores bools/non-int rounds, and leaves the default text byte-identical (existing exact-string test). New test covers 1/2/8 rounds. risk_gate: T2. No behaviour change in the evolve loop.

@Birfy
Birfy enabled auto-merge (squash) November 7, 2026 20:10
@github-actions github-actions Bot added the risk:T2 Risk tier T2 (package code or an unnamed path), set by the controller from the diff label Nov 7, 2026
@Birfy
Birfy merged commit 38de250 into main Nov 7, 2026
9 checks passed
@Birfy
Birfy deleted the fix/872-dead-reflector-rounds branch November 7, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:T2 Risk tier T2 (package code or an unnamed path), set by the controller from the diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plan: missing-reflector-key warning says 'fails after two rounds' on a --rounds 1 quick trial

1 participant