Repository navigation
fix(cli): dead-reflector warning names the rounds the spec will run - #873
Merged
Merged
Conversation
Collaborator
Author
|
Verdict: PASS (tip f74c6e0) Reviewed the diff: the helper only changes the wording of a warning, clamps to |
Birfy
enabled auto-merge (squash)
November 7, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #872
The
plan/algorithms runpreflight for areflect: openai_compatibleblock with an unset key always said the run "fails after two rounds". The loop actually stops aftermin(evolve.rounds, PROPOSE_FAIL_ROUNDS)rounds, so the--rounds 1 --workers 1quick trial was told the wrong thing._propose_fail_rounds_text(spec)readsPROPOSE_FAIL_ROUNDSfromevolutionand the spec'sevolve.rounds; wording is unchanged when rounds is unset or ≥2 (existing exact-string test still passes).changelog.d/872-dead-reflector-rounds.md.Local:
pytest -k "cli or preflight or plan or algorithms"green (withARK_API_KEYunset;test_present_host_passesis env-sensitive to that key on this machine, unrelated).