[azfoo]

🤖 Claude

Copies #621 (beat units and time signatures)'s units.py into tilia_core.timemap again, so the two files stay the same. The core's first copy came in with #706 (beat-unit rules in the core).

• tilia_core/timemap/units.py is feat: beat patterns, beat units, time signatures and quarter stamps #621's tilia/timelines/beat/units.py at 07cb6d4f, unchanged: the same git blob. Since a17bbd83, feat: beat patterns, beat units, time signatures and quarter stamps #621 has made four changes:
  • it refuses a unit longer than MAX_UNIT_LENGTH (32 characters) before Fraction() reads it, so a unit reads the same on every Python, and the error message cuts the unit short;
  • MeasureMeter holds tuples, so a meter can be hashed;
  • beat_unit_id is str | None, and the docstring says what it names in the app and in the core;
  • quarter_length is exact when given an int.
• meters_of passes the units and beat values as tuples, as feat: beat patterns, beat units, time signatures and quarter stamps #621's _compute_measure_meters now does.

Tests

• test_timemap_units.py ports feat: beat patterns, beat units, time signatures and quarter stamps #621's new TestParseUnits cases: the longest unit read, a longer one refused with a shortened message, and a 5,000-digit unit refused whatever Python's digit limit is.
• test_timemap_meters.py compares tuples, and adds feat: beat patterns, beat units, time signatures and quarter stamps #621's test_meters_can_be_hashed and test_quarter_length_is_exact.
• test_timemap_rows.py and test_timemap_meters.py check that a beat unit longer than 32 characters is left out when a timeline is read, so the unit before it carries on.
• uv run --package tilia-core pytest packages/tilia-core -q: 404 passed on v1-prerelease, which now has Move #621's beat unit rules into tilia_core.timemap, and compute each measure's meter #706 and feat(core): the measure table's structure and the time map's positions #707 (table and positions), and each commit passes on its own. python scripts/check_packages.py passes. black and ruff are clean.

Guarantees. I neutralised the code behind each one, ran the suite (404 tests), then restored it:

Guarantee	Code neutralised	Tests failing
a unit over 32 characters is refused, and left out when read	too_long or removed	4
the message cuts a long unit short	shown = item	3
a meter's units are a tuple	units=units in meters_of	5
a meter's beat values are a tuple	no tuple() in meters_of	11
quarter_length is exact for an int	no Fraction()	1

Part of TimeLineAnnotator/project-management#247

🤖 Generated with Claude Code

[azfoo]

🤖 Claude

Checked against #621 (beat units and time signatures) at 07cb6d4f: no problems found. This leaves the approval to @FelipeDefensor.

• The copy. packages/tilia-core/src/tilia_core/timemap/units.py and #621's tilia/timelines/beat/units.py at 07cb6d4f are the same blob (3ca97a74), and feat/beat-unit is still at 07cb6d4f.
• meters_of changes only by the two tuple()s, as #621's _compute_measure_meters has them. The _BeatUnit docstring change is wording.
• The ported tests are #621's, case for case: the three new TestParseUnits tests, test_meters_can_be_hashed and test_quarter_length_is_exact. The lists-to-tuples changes in test_timemap_meters.py change no expected value.
• Each commit passes on its own: 399, 402 and 404 tests at e5337b28, e2b1e6a8 and c6584d8f.
• The guarantees table reproduces exactly. Neutralising each piece of code in turn gave 4, 3, 5, 11 and 1 failing tests, and 404 passed again once restored.
• v1-prerelease has moved since this branch was cut (#731, the importers' setup), and no file under timemap changed. Rebased locally, without pushing, it has no conflicts and 445 tests pass, so a rebase merge needs no new push.
• CI is green on all three systems.
• The spec now describes this copy: a meter's units and beat_values are tuples, and beat_unit_id is str | None in both copies (WP9's data-model.md, on TimeLineAnnotator/project-management#253's branch).

#736 (time signatures in the measure table) is stacked on this branch. Once this merges, it moves to v1-prerelease.