Conversation
9 tasks
…roman/tinychat-native-release-20260915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meeting-publication migration needs a native server that supports immutable snapshots and a temporary legacy-write barrier. This prepares 1.17.0 on top of #230 and allows the existing deployment workflow to promote an already-built image by digest.
The Cargo manifest, lockfile and changelog agree on the version. For a normal deployment, the workflow now pins the exact dstack build output digest. A manual digest promotion skips rebuilding, verifies the selected image’s revision and version against the checked-out source, and then uses that immutable digest in the existing production compose. Deployment inputs, storage configuration, Phala CLI version and secrets remain unchanged. Two Rust unauthorized-error constructors now accept
Box<Resource>so strict checks pass on the current compiler; authorization decisions and error messages are preserved.Validation completed locally:
The local native test binary used local storage without default features. Final release source is
461e387b74c6760c5b48a265dca6a258667837c0, incorporating #230 through59dfcc1. Current Rust 1.98.1 strict workspace/all-target Clippy and formatting pass locally. Final core/node library checks report 315 and 361 passes (five PostgreSQL tests skipped locally); the preceding Linux run passed all PostgreSQL-backed workspace tests. The final Linux CI run passed all six jobs, including 785 workspace tests and all five PostgreSQL integration tests (seven README doctests ignored). All 255 Rust files match the release branch exactly; its four additional changes are the version/lockfile, changelog and image-promotion workflow.The final build-only container workflow is running with deployment disabled. The production-feature artifact and remote convergence remain separate validation steps; no production deployment or live catalog conversion is claimed here.
Rollout constraint: the guard adds a central SeaORM migration. An old 1.16.0 binary cannot simply restart against that applied migration. Recovery must retain a compatible migration list and, for activated catalogs, publication support and writer fences. See migration controls and recovery.
This is a draft stacked on #230. The operator sequence is build-only dispatch with
image_version=1.17.0and deployment disabled, inspect the resulting artifact, then promote that same source commit and reviewed digest. Publishing a version tag is not the build-only step because it triggers deployment.