feat(news): restore layered timeline reading and Market navigation - #1383
Merged
Conversation
|
Someone is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Submission check: the PR is open against dev at head a8c060c. Vercel currently reports FAILURE: Authorization required to deploy. This is an external-fork preview authorization gate; no deployment was authorized or bypassed. Maintainer action is required for the hosted preview. Local build/browser evidence and the non-green Windows full-suite result are recorded in the PR body; baseline failures are tracked in #1382. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer integration and acceptance
The contributor's original commit is preserved. The branch now includes current
dev(7fdf5ca5) and maintainer adjustments accepted through a running, isolated AliceProject preview:Final verification on
b5dd6473pnpm exec tsc --noEmitand UIpnpm --dir ui exec tsc -b: passed./market/news?category=us&view=positive: correct NVDA/SPY records.git diff --check: passed.Vercel's external-fork check remains an authorization-required deployment failure, not a build/test failure. The latest prior
devCLI Installer Smoke completed successfully. Windows baseline failures originally reported by the contributor remain tracked in #1382. Tag semantics remain in #1380/#1381; the separate Symbol substring-matching defect is explicitly deferred in #1387.Summary
Restore a scan-first news reading stream: a distinct headline, visible summary beneath it, left-hand timestamps, and directly visible editorial imagery. Submit the accepted news-only work against current
dev, without the unrelated quote directory, dependency upgrades, or tool changes in the original working tree.Closes #1379.
Included increments
Verification
Frozen-lockfile installation completed. Tests use Node 22.23.2, matching the CI major, rather than this machine's Node 26 host runtime. No dependency changes or storage shims are included.
Passed
pnpm exec tsc --noEmitpnpm --dir ui exec tsc -bpnpm --dir ui build— 3,705 modules; existing large-chunk warning remains.pnpm --package=node@22.23.2 dlx node node_modules/vitest/vitest.mjs run src/domain/news/collector/rss-parser.spec.ts src/webui/routes/news.spec.ts ui/src/demo/handlers/newsList.spec.ts ui/src/components/MarketSidebar.spec.tsx ui/src/tabs/__tests__/store.spec.ts ui/src/pages/NewsPage.spec.tsx ui/src/hooks/useNewsFeed.spec.ts— 7 files, 69 tests passed.git diff --cached --check/market/news?category=us&view=positive: the expected NVDA/SPY stories; category selection preserves the view. News navigation DOM survives News → Browse Markets → News. On phone, selecting US Stocks updates the route and closes the drawer (zero remaining dialogs).Full-suite result — not green
pnpm --package=node@22.23.2 dlx node node_modules/vitest/vitest.mjs run(the rootpnpm testrunner): 717 files passed, 7 failed, 5 skipped; 6,410 tests passed, 25 failed, 114 skipped in 310.14s.Failures are in unchanged CLI/headless/Windows environment suites, not the news or UI changes. A separate pristine checkout of base
88548b50717ef13e556f42b4882bd1e0de7116b0reproduces 24 failures across the same seven files. The additional full-suite failure is the headless watchdog case in that same failing subprocess boundary; it passed the isolated baseline selection. Reproduction, exact symptoms, and ownership are recorded in #1382. The PR does not weaken tests, add skips, or fold unrelated portability fixes into the news change.The workstation-mandated
cargo test --workspace --no-fail-fastwas also attempted from the repository root; it cannot run because this TypeScript repository has noCargo.toml.Boundary touch
Read-only Alice news HTTP query/shaping, RSS collection metadata, UI state and navigation, and demo handlers. No trading writes, UTA ownership, credentials/authentication, migrations, managed runtime, signing, packaging, dependency upgrades, or release/version changes. HTTP(S) image URL handling excludes embedded credentials at the backend boundary.
Non-goals
This is an external fork contribution for maintainer review; no merge or release is requested automatically.