Add MS Windows CI - #190
Open
rocky wants to merge 3 commits into
Open
Conversation
rocky
force-pushed
the
add-windows-ci
branch
9 times, most recently
from
August 16, 2026 14:20
bd29a31 to
a7c9250
Compare
echoix
reviewed
Aug 16, 2026
Comment on lines
+17
to
+19
| - name: Install dependencies | ||
| run: | | ||
| choco install mingw make -y |
There was a problem hiding this comment.
It seems weird to me that you
need mingw (and make) from choco, while you are installing msys2 below, which installs mingw too.
Collaborator
Author
There was a problem hiding this comment.
@echoix, thanks for all of the suggestions. Trying now to see if this step can be removed.
MS Windows and Github's CI are definitely not my strong points.
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.