Repository navigation
ci: run Tests with pnpm 10 and a frozen lockfile - #41
Merged
Merged
Conversation
pnpm-lock.yaml is lockfileVersion 9.0, written by pnpm 10. The workflow installed with pnpm 8, which cannot read that format, so every run has been re-resolving from scratch and rewriting the lockfile (+10377/-14965 lines). That pulls libsodium-wrappers-sumo 0.7.16 instead of the locked 0.7.13, whose types no longer match packages/crypto/src/symmetric.ts, and the build fails in postbuild: symmetric.ts(150,39): error TS2554: Expected 3-4 arguments, but got 2. symmetric.ts(152,32): error TS2339: Property 'tag' does not exist on type ... Reproduced locally with node 18 + pnpm 8 (fails identically) and with node 20 + pnpm 10 --frozen-lockfile (builds). Every Tests run on main since August has failed this way. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Testsrun onmainsince early August has failed at Install and build, before any test runs:Cause
pnpm-lock.yamlislockfileVersion: '9.0', written by pnpm 10. The workflow installs with pnpm 8, which cannot read that format, so each run silently re-resolves from scratch — the install rewrites the lockfile by +10377/−14965 lines — and picks uplibsodium-wrappers-sumo0.7.16 instead of the locked 0.7.13. 0.7.16's bundled types changed the signature ofcrypto_secretstream_xchacha20poly1305_pull, andpackages/crypto/src/symmetric.tsno longer type-checks against them.Reproduced locally on a clean copy of
release/10.0.0:pnpm buildpnpm installpnpm install --frozen-lockfileChange
.github/workflows/tests.yaml: pnpm 8 → 10, node 18 → 20,pnpm install→pnpm install --frozen-lockfile(so a stale lockfile fails loudly instead of drifting), and the three actions bumped to their node20 releases.Nothing in the code changes. Whether
symmetric.tsshould also be made to compile against sumo 0.7.16 is a separate question — this PR only makes CI test what the lockfile says.Once this lands, re-running the
Testscheck on #40 should go green:pull_requestruns use the workflow from the merge of head and base.🤖 Generated with Claude Code