Repository navigation
ci: isolate public tests and route trusted deploys separately - #23
Merged
Merged
Conversation
TueJon
marked this pull request as ready for review
October 24, 2026 15:10
TueJon
commented
Oct 24, 2026
TueJon
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: ship_it — no blocking findings at 33c0e33.
Reviewed the exact head. Diff is limited to .github/workflows/site.yml; no site file or target-owned handler is touched. Exact-head CI: test passed on runner vd-fw-webmcpify-at-public (labels tuejon-ci,ci-public), including the new Verify runner isolation step; deploy is skipped for PR events as expected.
Notes (non-blocking):
deploynow needs thetuejon-deploylabel, which no runner carries yet — the live runner list for this repo isvd-fw-webmcpify-at(tuejon-ci) andvd-fw-webmcpify-at-public(tuejon-ci,ci-public). The merge commit itself triggers a push deploy, so the label must be added to site runner id 2 before merge (cutover step 3 inknowledge/vd-fw/public-ci-runner-isolation.md). That is host rollout, not a change required in this PR; flagging only to keep merge order explicit.- The isolation assertions are host-coupled by design (account
ci-public, no sudo/docker groups, no/home/vdaccess via ACL +ProtectHome). They currently pass and fail closed if the unit/ACL regresses; changing the runner account or path layout later will require updating this step. - Residual, already stated in the PR body: an approved fork workflow can still edit
runs-onand select the privilegedtuejon-deployrunner — labels are routing, not authorization. Not introduced by this diff.
CI is green at this head; no further source change requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public PR tests currently run as
vdalongside host deployment credentials. Route them to the preparedci-publicaccount, which has no sudo/Docker access and cannot traverse/home/vd. Keep fork guards and approval requirements, and verify the account boundary in each run.Validation: this PR runs the existing full CI on the isolated runner. Host rollout is tracked by
vdfw-runner-privilege-separation-2026-10-22; existing runner retirement follows green main/deploy evidence and the required host approval.The site deployment job stays on
vdwith the separatetuejon-deploylabel and its existing forced-command key. Merge is held for production cutover approval; no site files change. Labels route jobs and do not prevent an approved malicious workflow from targeting the deploy runner.