Skip to content

Pin CI to the patched Node 22 security release - #27

Merged
TueJon merged 1 commit into
mainfrom
security/node-20261112
Nov 12, 2026
Merged

TueJon merged 1 commit into
mainfrom
security/node-20261112

Conversation

@TueJon

@TueJon TueJon commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Pin CI to Node 22.23.5 so setup-node cannot select an older cached Node 22 version after the November security release. Runtime code and existing runner isolation checks are unchanged.

Validation: checksum-verified Node 22.23.5, npm ci (audit 0), npm run check (79 tests pass), independent review.

@TueJon TueJon self-assigned this Nov 12, 2026
@TueJon TueJon added the bug Something isn't working label Nov 12, 2026

@TueJon TueJon left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Pin CI to the patched Node 22 security release

First review at this head (6147865). One-line CI pin, no prior reviews. CI check job is green at this head; ai-review is this run.

What I checked

  • Diff is exactly one line in .github/workflows/ci.yml: node-version: 22 → 22.23.5. Runner labels, isolation-verification step, fork guards (head.repo.full_name check), and permissions: contents: read are all untouched.
  • Repo rules (AGENTS.md): this repo is an agent skill; its hard rules concern SKILL.md token-efficiency, runtime dependency-freedom, TS/JS sync, and version-manifest sync. A CI-only Node pin touches none of that surface.

Findings

None. No blocking and no non-blocking findings:

  • Product fit: pinning CI to a patched security release so a self-hosted runner with a stale cached Node 22 cannot silently test against a vulnerable runtime is a legitimate, minimal hardening step.
  • Correctness: exact pin resolves (proven by the green check run at this head, which itself runs setup-node → npm ci → npm run check). Trade-off is known and accepted: future Node security fixes need another one-line bump rather than floating forward automatically.
  • Security / external effects / migration / docs: no secrets, no new runners or permissions, no schema or runtime-code change, no docs invalidated, no release-steps/-style follow-up needed.

Verdict

Clean one-line security pin, CI green at this head. Nothing further required.

@TueJon
TueJon merged commit afe913c into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant