Repository navigation
Conversation
The three removed rules name functions the extension never imports, so they only defined unused local functions. ReverseDiff 1.18.8 (JuliaDiff/ReverseDiff.jl#328) adds the method to `typeof(f)`, which requires `f` to exist, so loading fails with `UndefVarError`. Assisted-by: Claude Code <noreply@anthropic.com>
Distributions now prints `LogNormal()` as a multi-line block, so the doctests suppress that output instead of matching it. Assisted-by: Claude Code <noreply@anthropic.com>
ReverseDiff re-runs the `@grad` body on each forward pass of a recorded tape but keeps the pullback from recording time. Partials computed from tracked inputs in the body therefore raise `tape has finished recording` on ReverseDiff 1.18.4+, and partials computed in the body from any values are stale when a tape is replayed at a new input, as they already were before 1.18.4. Assisted-by: Claude Code <noreply@anthropic.com>
Reusing a tape through `find_alpha` at a new input raised a `MethodError` when some of its arguments were untracked, for example the inverse `PlanarLayer` with plain `Float64` parameters. ReverseDiff stores untracked inputs of a recorded call as plain values, but the `@grad` signature required `TrackedReal` for every argument. The tracking method needs no change: mixed arguments reach it through the promotion in `find_alpha(::Real, ::Real, ::Real)`. Assisted-by: Claude Code <noreply@anthropic.com>
Contributor
|
Bijectors.jl documentation for PR #489 is available at: |
Member
|
I have personally reviewed the PR and everything looks good to me. But before approving lets try my review bot here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ReverseDiff 1.18.8,
BijectorsReverseDiffExtfails to precompile (UndefVarError: pd_from_upper not defined). The extension declared@grad_from_chainrulesrules forpd_from_upper,_link_chol_lkj_from_upperand_link_chol_lkj_from_lowerwithout importing them; up to 1.18.7 these defined unused local functions, but 1.18.8 (JuliaDiff/ReverseDiff.jl#328) requires the functions to exist. Deleting the rules keeps current behaviour: ReverseDiff gradients matchmainfor the affected bijectors on Julia 1.12.The
find_alpharule now computes its partials in the pullback from the current inputs, removing thetape has finished recordingerror on ReverseDiff 1.18.4+ and wrong gradients when a tape is reused at a new input. It also accepts untracked arguments, so reusing a tape with untrackedPlanarLayerparameters no longer raises aMethodError. Thelinkandinvlinkdoctests no longer print aLogNormal, whose display changed in Distributions. Bumps to 0.16.4.Mooncake CI failed tests are unrelated.