Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 85.29% 85.34% +0.04%
==========================================
Files 52 52
Lines 4700 4714 +14
==========================================
+ Hits 4009 4023 +14
Misses 691 691 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
DynamicPPL.jl documentation for PR #1547 is available at: |
BenchmarksPerformance Ratio: gradient time divided by log-density time. For very small models these ratios are noisy across runs and machines; raw primal and gradient timings are more reliable. The benchmarks are aimed at DynamicPPL developers and mainly catch obvious allocation or type-stability regressions. See benchmark notes for details. Primal times: EnvironmentJulia Version 1.13.4 Commit c1ac32ab733 (2026-11-13 17:30 UTC) Build Info: Official https://julialang.org release Platform Info: OS: Linux (x86_64-linux-gnu) CPU: 4 × AMD EPYC 7763 64-Core Processor WORD_SIZE: 64 LLVM: libLLVM-20.1.8 (ORCJIT, znver3) GC: Built with stock GC Threads: 1 default, 1 interactive, 1 GC (on 4 virtual cores) |
shravanngoswamii
left a comment
There was a problem hiding this comment.
Looks good to me!
Agent found this:
AbstractPPL added of in 0.15.3. So we should raise the minimum in DynamicPPL compat to 0.15.3
`of(vnt)` describes a VarNamedTuple's storage as an AbstractPPL template. Nothing consumes it yet: the binding API added in a later change accepts such templates in `condition` and `fix`. Assisted-by: Claude Code <noreply@anthropic.com> Assisted-by: Codex <codex@openai.com>
|
Looks good to me |
Split of #1529 (part 4.2 of 12; part 4 comes as nine PRs).
Adds
AbstractPPL.of(vnt::VarNamedTuple), which describes aVarNamedTuple's storage as an AbstractPPL template. It supports numericArrays, nested fields, and scalars whose typeofpreserves. Other storage throws anArgumentError; this includes values set by index without a template, whose shape is only inferred. Nothing uses the method yet: part 4.4 letsconditionandfixtake such templates. Errors name the failing field by its dotted path, such asa.x. Tests cover a partly filled array in a nested field, a scalar, and both error paths.