Repository navigation
Add registration form, useRegister flow and toast - #11
Merged
Merged
Conversation
- ToastProvider (MUI Snackbar + Alert) with useToast; mounted above the routes so the toast survives the redirect - registerUser API client; attribution is omitted when none is stored - useRegister: on success start the session, clear attribution, show a welcome toast and go to the validated returnTo; no retry, attribution kept on error - RegisterForm with client validation matching the API rules, field and general server errors, pending state - End-to-end tests: attribution sent and cleared, return to the promo modal, unsafe returnTo ignored, failure keeps attribution, 409, client validation All three open questions are now decided (toast: MUI Snackbar with a small helper). Document the toast, the form and a known toast accessibility limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three open questions are now decided (toast: MUI Snackbar with a small helper). Document the toast, the form and a known toast accessibility limit.