Repository navigation
Add URL-driven modal stack - #9
Merged
Merged
Conversation
- Modal registry: welcome, promo, invite and signup params with value validation; typed openModal arguments - parseModals derives open modals from the URL in param order, ignoring invalid values and repeats - useModalStack: openModal / closeModal only change the URL (push a history entry, keep path and other params) - Four modals on the shared ModalFrame; single ModalRenderer in AppLayout; stacked modals with one backdrop - Tests for parsing, the hook, cold load, stacking, closing one of several, back/forward and in-app navigation Signed-out gating follows in Stage 7. Document modal content and stacking in routing-and-modals.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-out gating follows in Stage 7. Document modal content and stacking in routing-and-modals.md.