Preserve bidirectional unit identity in time-sequential ramp inputs - #43
Open
zack-dev-cm wants to merge 1 commit into
Open
zack-dev-cm wants to merge 1 commit into
zack-dev-cm wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #42 and #39; thanks to tytowatt for identifying the helper and example failures.
Joining prior dispatch to ramp bids on
unitalone duplicates generator/load rows, while a staleinitial_outputproduces suffixed columns. Join on(unit, dispatch_type)when available, validate cardinality, and retain authoritative prior output. New units without prior dispatch start at zero; missing ramp values remain available for validation.The solver regression also establishes the bidirectional-unit contract: both rows need signed net output, generation minus consumption, for the composite ramp constraints. With prior net generation of 4 MW and a 12 MW/hour ramp limit over five minutes, the next bound is 5 MW. Tests cover both signs and crossing zero. Historical unit-level seed output is already net output; single-direction loads retain their positive-consumption convention.
The example passes the three violation costs by keyword, as reported in #42. Scope is limited to the two helpers, their example calls and regressions.
Validation, based on
2d3cef0:Linux compatibility: the unchanged upstream interconnector test aborts with CFFI 2.x and passes with 1.17.1. Review the independently scoped #44 first; its installed-wheel checks pass on Python 3.9/3.12. This PR alone retains the existing dependency metadata.
These are contributor-reported results; upstream workflows await approval. Historical cache-dependent benchmarks and complete resolution of #39 are outside the validated scope. The signed-net-output and missing-identity contracts remain explicit review points.