Skip to content

ci(release): promote v0 only after PyPI publish, verify the published action #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uipreliga wants to merge 3 commits into
base: main
Choose a base branch
from
+642 −111
Open

ci(release): promote v0 only after PyPI publish, verify the published action #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cad104
ci(release): promote v0 only after PyPI publish, verify the published…
uipreliga Aug 4, 2026
818d1b1
fix(ci): code review fixes for the published-action verification
uipreliga Aug 4, 2026
e88efe0
fix(ci): harden promote ordering and stop preflight misdiagnosing hea…
uipreliga Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .claude/harness-candidates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,27 @@ Deferred lint/test guardrails surfaced during reviews. Promote to a `CExxx` rule
caught them. The cleanup plan explicitly deferred this as YAGNI for the
one-time purge, but any future doc rename/deletion re-opens the same blind
spot — caught in the 2026-07-03 open-source-docs-cleanup implementation run.

## From 2026-08-04 published-action verification review

- [ ] **CE034 — `VAR=$(… | grep …)` under `set -e` followed by an emptiness check
is a dead diagnostic.** With `set -euo pipefail`, a pipeline whose `grep` matches
nothing exits 1, so the assignment aborts the step *before* the
`if [ -z "$VAR" ]; then echo "::error::…"` branch that was written to report it —
the operator gets a bare exit 1 with no message. Also applies to `head -1`
closing the pipe early (SIGPIPE 141). Fix is `|| true` on the substitution,
letting the emptiness check own every failure mode. Detectable by matching
`\w+=\$\(.*\|\s*(grep|head)\b` inside a `run:` body whose script sets `-e`, then
requiring `|| true`/`|| :` on the same logical line. Caught by a reviewer in
`verify-published-action.yml`; **`actionlint` + shellcheck do NOT flag it**
(verified against the exact snippet), so the actionlint candidate above does not
subsume this one.
- [ ] **Runtime-key parity for `run.json` consumers outside `src/`.** The e2e gate in
`verify-published-action.yml` reads `task_results[*].status` / `weighted_score` /
`total_tokens`, and `action.yml`'s score gate reads `weighted_score` / `task_id`.
These are string keys in shell/YAML that no test or type-checker binds to
`eval_result_to_task_dict` (`reports_experiment.py`), so renaming a key there
silently turns an external gate into a no-op — a reviewer here proposed
`final_status`, which does not exist in `run.json` and would have made a new
assertion dead on arrival. Guard: assert the key set that non-Python consumers
depend on, mirroring how CE030 pins doc/schema parity.
Loading
Loading