Skip to content

fix: correct KDE wallpaper reply and capability for get_wallpaper - #12

Open
BradleyBao wants to merge 2 commits into
UniDesktop:mainfrom
BradleyBao:fix/linux_kde_wallpaper
Open

BradleyBao wants to merge 2 commits into
UniDesktop:mainfrom
BradleyBao:fix/linux_kde_wallpaper

Conversation

@BradleyBao

Copy link
Copy Markdown

这个 PR 将会 Close #11

TL;DR

做了以下的修改:

  1. 由于 evaluateScript 返回的 D-Bus 的签名是 s 而不是 _,将evaluateScript call 的接受更改为了可接受 String 或者 空
  2. capabilities中删除了 GET_WALLPAPER 因为其未被实现并加入了TODO

问题

对于 1,由于 set_wallpaper_kde 的错误被捕获了导致进入了 set_wallpaper_x11 从而产生了来自 set_wallpaper_x11的无相关的错误

Failed: NotSupported("Neither feh nor nitrogen is available")

目前,PlasmaShell 的 evaluateScript 的 output type 为 s,官方仓库。
对于2,这是为了修复 #4 中的 p2-40,将 capabilities 中的 GET_WALLPAPER 删除以避免误导,并加入了 TODO。

@SRInternet
SRInternet self-requested a review October 27, 2026 16:44
@SRInternet SRInternet added bug Something isn't working enhancement New feature or request labels Oct 27, 2026
@SRInternet

Copy link
Copy Markdown
Member

Thank you for your repair. We are about to start the review process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux 壁纸能力声明错误,且 KDE 设置成功后仍可能返回错误

2 participants