Repository navigation
fix: correct KDE wallpaper reply and capability for get_wallpaper - #12
Open
BradleyBao wants to merge 2 commits into
Open
BradleyBao wants to merge 2 commits into
BradleyBao wants to merge 2 commits into
Conversation
Member
|
Thank you for your repair. We are about to start the review process! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 将会 Close #11
TL;DR
做了以下的修改:
evaluateScript返回的 D-Bus 的签名是s而不是 _,将evaluateScript call 的接受更改为了可接受String或者 空capabilities中删除了GET_WALLPAPER因为其未被实现并加入了TODO问题
对于 1,由于
set_wallpaper_kde的错误被捕获了导致进入了set_wallpaper_x11从而产生了来自set_wallpaper_x11的无相关的错误目前,PlasmaShell 的 evaluateScript 的 output type 为
s,官方仓库。对于2,这是为了修复 #4 中的 p2-40,将 capabilities 中的 GET_WALLPAPER 删除以避免误导,并加入了 TODO。