fix(rest/python): complete webhook-test checkouts by server-assigned id - #180
Open
vishkaty wants to merge 1 commit into
Open
Conversation
The webhook signing tests from Universal-Commerce-Protocol#169 drive create + complete through _completed_checkout using the client-supplied checkout id. Universal-Commerce-Protocol#167 made the server assign checkout ids, so on a tree containing both changes the complete call answers 404 RESOURCE_NOT_FOUND and every webhook test fails — the Python Server Tests job is red on main since Universal-Commerce-Protocol#169 merged (the two changes were each green when last exercised by CI, and the interaction only exists on the merged tree). Read the server-assigned id from the create response and complete against it. Full suite: 164 passed.
damaz91
added
status:needs-triage
damaz91
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The Python Server Tests job is red on main since #169 merged: every webhook signing test fails with
404 RESOURCE_NOT_FOUNDat the complete step.Root cause: an interaction between two individually-green changes, both mine. #169's
_completed_checkouthelper (written before #167 landed) creates a checkout and then completes it using the client-supplied id. #167 makes the server assign checkout ids, so on the merged tree the complete call targets an id that does not exist. Each PR passed CI when last run because the fork test job runs at review time — the combination only ever executed after both merged.Fix
_completed_checkoutreads the server-assigned id from the create response and completes against it (the same adjustment #167 applied to the other integration tests).Verification
ab78116: reproduced all webhook-test failures locally with the same 404.Apologies for the breakage — both halves were mine, and the lesson (re-run the suite against the merged tree when sibling PRs land between approval and merge) is taken.