Repository navigation
test(e2e): browser smoke test of the login captcha - #231
Merged
Merged
Conversation
Since v0.9.2 the dashboard login captcha always fails with "Verification
failed. Try again later." (console: "Challenge validation failed.").
Dependabot moved the bundled widget from altcha 3.2.4 to 3.4.0, whose
isChallengeV1 reads
typeof !!challenge && challenge === "object" && ...
so it compares the challenge object to the string "object" and never
recognises a v1 challenge, which is what GateCHA serves. 3.4.1 fixes the
check (`challenge !== null && typeof challenge === "object"`); 3.3.0 and
3.2.4 never had the bug.
Reproduced against the published v0.9.4 image and fixed on a binary built
from this branch: the widget reaches "Verified" and a full captcha login
lands on the dashboard. npm test (188) and npm run build pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
altcha 3.4.0 rejected every challenge GateCHA serves and shipped in v0.9.2-v0.9.4 with a green CI, because the unit tests mock the widget. This test runs the real thing: a Playwright Chromium against a built GateCHA binary, login captcha switched on through the admin API, clicks "I'm not a robot", waits for "Verified", signs in and lands on the dashboard. Checked both ways locally: passes with altcha 3.4.1, fails with 3.4.0 on "Verification failed. Try again later." (the production symptom). - web/e2e/login-captcha.e2e.ts, web/playwright.config.ts, npm run test:e2e (*.e2e.ts so Vitest does not pick it up; type-checked via tsconfig.node.json). - New `e2e` CI job: builds frontend + binary, starts it, installs Chromium, runs the test; uploads the Playwright report and prints the server log on failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
altcha 3.4.0 rejected every challenge GateCHA serves and shipped in v0.9.2–v0.9.4 with a green CI, because the unit tests mock the widget. This adds a real-browser test of exactly that path.
web/e2e/login-captcha.e2e.ts(Playwright 1.64.0, Chromium): enables the login captcha through the admin API, opens/login, clicks "I'm not a robot", waits for Verified, signs in and expects the Dashboard.web/playwright.config.ts,npm run test:e2e; files are*.e2e.tsso Vitest ignores them, and they are type-checked throughtsconfig.node.json.e2eCI job: builds the frontend and the binary, starts GateCHA, installs Chromium, runs the test; on failure prints the server log and uploads the Playwright report + trace.Verification (local)
Expected "Verified", received"… Verification failed. Try again later."npm test(188) andnpm run build(incl. type check of the e2e files) pass.Stacked on #229 (base
fix/altcha-3.4.1) so its CI runs on a fixed widget; GitHub retargets it tomainwhen #229 merges.🤖 Generated with Claude Code