New pest killing mode, mana regex fix, and configurable swap cooldown - #103
Draft
osamabeinglagging wants to merge 4 commits into
Draft
osamabeinglagging wants to merge 4 commits into
osamabeinglagging wants to merge 4 commits into
Conversation
Added a GUI slider and backing logic so the wait time after a loadout swap finishes can be tuned instead of using a fixed delay.
Contributor
|
Is this the actual osama |
Contributor
Author
|
Possibly |
osamabeinglagging
marked this pull request as draft
September 2, 2026 00:52
rdbtCVS
reviewed
Sep 2, 2026
| (value) => (this.pestSpawnSwapCooldown = Math.round(value)), | ||
| 'Switches to the pest spawning loadout at or below this cooldown in seconds.' | ||
| ); | ||
| this.addSlider('Post Swap Delay', 1, 20, this.postSwapDelay, (value) => (this.postSwapDelay = Math.round(value))); |
Member
There was a problem hiding this comment.
should prob be in FarmingDelays.js
other than that, lgtm
pr is set as a draft, idk if thats purposeful or not.
Member
|
I skidded your regex fix, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
These changes were made to fix issues I was hitting locally. Not sure if they're the right fix for the project overall, or if there's context I'm missing. Happy to adjust or drop any of them if there's a better approach or they're not actually needed.
Changes