refactor: remove unused server scaffolding - #1
Open
KyleDerZweite wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the workspace by removing unused server/template scaffolding, simplifying local check tooling, and introducing a minimal Matrix API smoke test pipeline using Complement.
Changes:
- Simplified
scripts/check.shto run a fixed set of Cargo + cargo-deny checks directly. - Removed multiple unused workspace crates/types and pruned workspace dependencies/lockfile accordingly.
- Added a Complement smoke-test GitHub Actions workflow and a minimal runtime image/entrypoint for running the server under Complement.
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/check.sh | Replaced the featureful check wrapper with direct cargo fmt/clippy/test and cargo deny commands. |
| docs/progress.md | Updated progress note to reflect Complement smoke coverage instead of Sytest baseline tracking. |
| docker/Dockerfile.complement | Added a minimal Debian-based image intended for running the release server binary in Complement. |
| docker/complement-entrypoint.sh | Added entrypoint that configures server env vars for Complement and execs the server. |
| crates/vauxl-server/src/main.rs | Adjusted config env parsing and changed wake channel payload to (). |
| crates/vauxl-server/Cargo.toml | Removed now-unused dependencies from the server crate. |
| crates/vauxl-push/src/lib.rs | Deleted unused template crate implementation. |
| crates/vauxl-push/Cargo.toml | Deleted unused template crate manifest. |
| crates/vauxl-media/src/lib.rs | Deleted unused template crate implementation. |
| crates/vauxl-media/Cargo.toml | Deleted unused template crate manifest. |
| crates/vauxl-matrix/src/state.rs | Removed WakeEvent and switched wake broadcast channel to Sender<()>. |
| crates/vauxl-matrix/src/routes/sync.rs | Switched room state query to get_full_room_state and uses unit wake notifications. |
| crates/vauxl-matrix/src/routes/rooms.rs | Updated wake sends to () after room events are written. |
| crates/vauxl-matrix/src/routes/media.rs | Removed unused thumbnail flag plumbing; all media endpoints call a single serve_media. |
| crates/vauxl-matrix/src/routes/login.rs | Removed unused LoginResponse type and narrowed serde imports. |
| crates/vauxl-matrix/src/routes/client_info.rs | Removed duplicate/unused client stubs and dead logout hash code. |
| crates/vauxl-matrix/src/db/sync.rs | Removed unused SyncRoom and duplicate get_room_state query. |
| crates/vauxl-matrix/src/db/keys.rs | Removed write-only OTK count upsert path; counts are derived from one_time_keys. |
| crates/vauxl-matrix/Cargo.toml | Made Ed25519 RNG feature explicit; removed unused deps/dev-deps. |
| crates/vauxl-identity/src/lib.rs | Deleted unused template crate implementation. |
| crates/vauxl-identity/Cargo.toml | Deleted unused template crate manifest. |
| crates/vauxl-federation/src/lib.rs | Deleted unused template crate implementation. |
| crates/vauxl-federation/Cargo.toml | Deleted unused template crate manifest. |
| crates/vauxl-crypto/Cargo.toml | Removed unused vodozemac and made Ed25519 RNG feature explicit. |
| crates/vauxl-admin/src/lib.rs | Deleted unused template crate implementation. |
| crates/vauxl-admin/Cargo.toml | Deleted unused template crate manifest. |
| Cargo.toml | Removed unused workspace members and pruned workspace dependencies accordingly. |
| Cargo.lock | Large lockfile reduction after workspace pruning; dependency set updated (incl. event-listener). |
| .sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json | Removed stale SQLx offline cache entry for deleted OTK count upsert query. |
| .github/workflows/sytest.yml | Replaced Sytest workflow with Complement-based Matrix API smoke test workflow. |
Files not reviewed (1)
- .sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 30 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- .sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json: Generated file
Suppressed comments (2)
scripts/check.sh:7
- scripts/check.sh runs cargo commands without setting SQLX_OFFLINE. Because the codebase uses sqlx::query! macros and CI/Docker consistently set SQLX_OFFLINE=true, running this script in a fresh dev environment (without DATABASE_URL) is likely to fail at compile time. Set SQLX_OFFLINE=true in the script to match the repository’s offline workflow.
cargo fmt --all -- --check
RUSTFLAGS="-D warnings" cargo clippy --all-targets --all-features
cargo test --all
cargo deny check advisories licenses bans sources
docs/progress.md:1
- This sentence reads as singular but uses the plural verb “runs”. Adjust to “check run” for grammatical correctness.
P1 Matrix API smoke: one pinned official Complement `TestVersionStructure` check runs. Full Client Server API and federation compatibility remains unmeasured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied
Retained and compatibility
Checks