Skip to content

refactor: remove unused server scaffolding - #1

Open
KyleDerZweite wants to merge 5 commits into
mainfrom
codex/ponytail-ultra
Open

refactor: remove unused server scaffolding#1
KyleDerZweite wants to merge 5 commits into
mainfrom
codex/ponytail-ultra

Conversation

@KyleDerZweite

Copy link
Copy Markdown
Member

Applied

  • Replaced the check script wrapper with direct Cargo and cargo deny checks.
  • Removed five unused template workspace crates and unused manifest edges. Ed25519 RNG features are now explicit after removing hidden vodozemac feature coupling.
  • Removed write only device OTK count updates and their stale SQLx cache entry. OTK responses still query one_time_keys directly.
  • Removed duplicate client stubs, the duplicate room state query, LoginResponse, SyncRoom, the logout hash, the wake payload, and the ignored media flag.

Retained and compatibility

  • Kept migrations/002_otk_counts.sql unchanged. Existing tables and data remain but are no longer read or written. A future approved migration can remove the table if data removal is authorized.
  • Matrix HTTP responses remain unchanged.
  • The Rust API no longer exposes LoginResponse, SyncRoom, or WakeEvent. No repository callers exist. External consumers should use JSON login responses, room tuples, and a unit wake message.
  • The workspace no longer exposes the five template packages. Add a package again when it has real behavior and a caller.
  • scripts/check.sh no longer accepts modes. Run individual Cargo commands for a smaller check or formatting fix.
  • No code finding was skipped. Only deletion of existing migration history and database data was intentionally retained.

Checks

  • Cargo formatting for all workspace packages in check mode: passed.
  • Bash syntax for scripts/check.sh: passed.
  • Cargo check for the locked workspace, every target and feature, with SQLx offline: passed.
  • Cargo tests for every workspace target and feature with SQLx offline: passed, 9 tests.
  • Cargo Clippy for every workspace target and feature with warnings denied and SQLx offline: passed.
  • Cargo metadata with locked resolution and no dependencies: passed.
  • Cargo deny for advisories, licenses, bans, and sources: failed on preexisting RUSTSEC-2026-0221 for event-listener 5.4.1. The base lockfile contains the same version. Licenses, bans, and sources passed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the workspace by removing unused server/template scaffolding, simplifying local check tooling, and introducing a minimal Matrix API smoke test pipeline using Complement.

Changes:

  • Simplified scripts/check.sh to run a fixed set of Cargo + cargo-deny checks directly.
  • Removed multiple unused workspace crates/types and pruned workspace dependencies/lockfile accordingly.
  • Added a Complement smoke-test GitHub Actions workflow and a minimal runtime image/entrypoint for running the server under Complement.

Reviewed changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/check.sh Replaced the featureful check wrapper with direct cargo fmt/clippy/test and cargo deny commands.
docs/progress.md Updated progress note to reflect Complement smoke coverage instead of Sytest baseline tracking.
docker/Dockerfile.complement Added a minimal Debian-based image intended for running the release server binary in Complement.
docker/complement-entrypoint.sh Added entrypoint that configures server env vars for Complement and execs the server.
crates/vauxl-server/src/main.rs Adjusted config env parsing and changed wake channel payload to ().
crates/vauxl-server/Cargo.toml Removed now-unused dependencies from the server crate.
crates/vauxl-push/src/lib.rs Deleted unused template crate implementation.
crates/vauxl-push/Cargo.toml Deleted unused template crate manifest.
crates/vauxl-media/src/lib.rs Deleted unused template crate implementation.
crates/vauxl-media/Cargo.toml Deleted unused template crate manifest.
crates/vauxl-matrix/src/state.rs Removed WakeEvent and switched wake broadcast channel to Sender<()>.
crates/vauxl-matrix/src/routes/sync.rs Switched room state query to get_full_room_state and uses unit wake notifications.
crates/vauxl-matrix/src/routes/rooms.rs Updated wake sends to () after room events are written.
crates/vauxl-matrix/src/routes/media.rs Removed unused thumbnail flag plumbing; all media endpoints call a single serve_media.
crates/vauxl-matrix/src/routes/login.rs Removed unused LoginResponse type and narrowed serde imports.
crates/vauxl-matrix/src/routes/client_info.rs Removed duplicate/unused client stubs and dead logout hash code.
crates/vauxl-matrix/src/db/sync.rs Removed unused SyncRoom and duplicate get_room_state query.
crates/vauxl-matrix/src/db/keys.rs Removed write-only OTK count upsert path; counts are derived from one_time_keys.
crates/vauxl-matrix/Cargo.toml Made Ed25519 RNG feature explicit; removed unused deps/dev-deps.
crates/vauxl-identity/src/lib.rs Deleted unused template crate implementation.
crates/vauxl-identity/Cargo.toml Deleted unused template crate manifest.
crates/vauxl-federation/src/lib.rs Deleted unused template crate implementation.
crates/vauxl-federation/Cargo.toml Deleted unused template crate manifest.
crates/vauxl-crypto/Cargo.toml Removed unused vodozemac and made Ed25519 RNG feature explicit.
crates/vauxl-admin/src/lib.rs Deleted unused template crate implementation.
crates/vauxl-admin/Cargo.toml Deleted unused template crate manifest.
Cargo.toml Removed unused workspace members and pruned workspace dependencies accordingly.
Cargo.lock Large lockfile reduction after workspace pruning; dependency set updated (incl. event-listener).
.sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json Removed stale SQLx offline cache entry for deleted OTK count upsert query.
.github/workflows/sytest.yml Replaced Sytest workflow with Complement-based Matrix API smoke test workflow.
Files not reviewed (1)
  • .sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/vauxl-matrix/src/routes/rooms.rs Outdated
Comment thread docker/Dockerfile.complement

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 30 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • .sqlx/query-078952dbae56d4c379132e87ce2fbb5f5a2c8074dffc2b6af58bb7c137a9b148.json: Generated file
Suppressed comments (2)

scripts/check.sh:7

  • scripts/check.sh runs cargo commands without setting SQLX_OFFLINE. Because the codebase uses sqlx::query! macros and CI/Docker consistently set SQLX_OFFLINE=true, running this script in a fresh dev environment (without DATABASE_URL) is likely to fail at compile time. Set SQLX_OFFLINE=true in the script to match the repository’s offline workflow.
cargo fmt --all -- --check
RUSTFLAGS="-D warnings" cargo clippy --all-targets --all-features
cargo test --all
cargo deny check advisories licenses bans sources

docs/progress.md:1

  • This sentence reads as singular but uses the plural verb “runs”. Adjust to “check run” for grammatical correctness.
P1 Matrix API smoke: one pinned official Complement `TestVersionStructure` check runs. Full Client Server API and federation compatibility remains unmeasured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants