Repository navigation
Grant permanent MCP Events subscriptions on explicit ttlMs null - #5
Merged
Merged
Conversation
VeraPyuyi
marked this pull request as ready for review
October 23, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the official MCP Events contract, an explicit
ttlMs: nullrequests a subscription without expiration; the server grants it and returnsrefreshBefore: null.Permanence is a persisted flag with zero expiry; zero expiry alone never grants it. Omitted TTL keeps the one-hour default and numeric TTL keeps the 60s..24h range, so a numeric refresh downgrades a permanent grant. Delivery still requires enabled state and callback verification, and unsubscribe, revoke, disable, auth continuity changes and signing-secret replacement keep their existing invalidation rules. Event and bridge grants are intersected. Status reports an active permanent subscription with omitted dates.
Verified: RED then GREEN lifecycle, downgrade, HTTP-null and status tests; focused race; full
go test -race ./...passed in 137.58s; vet, gofmt and diff checks clean.