Repository navigation
Report completed updates, tune read failures and crash locations accurately - #172
Merged
Merged
Conversation
…rately An installer that ends with a failure code after Setup installed and registered the target version no longer turns a completed update into a failure: when the recorded target is the running build and the version Setup registered, the update is reported as installed. Tune read failures carry the methods on the failing stack, like crash reports, so each of the reader's checks is its own problem instead of one bare InvalidDataException. A crash signature includes the module Wisp captured at the fault when there is one, so a renderer, driver or hook fault no longer shares a signature with every fault Windows attributes to wisp.exe. Wisp Tools accepts the signature with or without that line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reporting fixes found in the 2.7.x diagnostics.
Completed updates reported as failed
UPDATE_INSTALLER_EXIT_FAILED. The newly installed version then showed "The previous update did not complete" and reported a failure.UpdateApplyContract.UninstallRegistryKey, and the updater's registration reader uses it. A test checks the key against the AppId ininstaller/Wisp.iss.Tune read failures without detail
InvalidDataExceptionfrom the tune reader looked the same. They now carry the methods on the failing stack, using the same projection as crash reports. That projection isCrashReport.DescribeExceptions, whichCrashReport.Capturenow uses too. The exception message stays local.Crash signature
Steam and Xbox
Verification
dotnet format whitespacepasses on the changed files.NativeTuneRead.Bytes;Not verified