Repository navigation
x86/microcode: spell out the extended table size grouping - #122
Merged
FengHeting merged 3 commits intoNov 2, 2026
Merged
Conversation
The extended signature table is the signature records plus the fixed header; make that grouping explicit in the size expression instead of relying on operator precedence. Signed-off-by: MicroFish <2609948707@qq.com>
FengHeting
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The extended signature table size is the signature records plus the fixed header. Make that grouping explicit in
((size_t)et->count * INTEL_MC_EXT_SIG_SIZE) + INTEL_MC_EXT_HEADER_SIZEinstead of relying on operator precedence.No functional change; silences clang-tidy
readability-math-missing-parentheses.Testing
Default configuration builds.