Repository navigation
ata: reuse firmware-configured DMA with PIO fallback - #128
Merged
Merged
Conversation
The firmware pairs its host timing with the drive's DMA mode. Probe each drive without sending SET FEATURES or programming vendor timing registers, then compare a PIO and a DMA read of the same sectors once at boot. A failed check, a missing BAR4, or a runtime bus-master error drops the drive to PIO; ATA retries the same request in PIO, ATAPI resumes from the completed offset, and a stuck BSY resets the channel. ATAPI capacity probing follows REQUEST SENSE retries and maps a missing medium to -ENOMEDIUM. Signed-off-by: MicroFish <2609948707@qq.com> Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PATA driver sent SET FEATURES to put the drive into UDMA/MWDMA but never programmed the chipset timing registers, so DMA did not work on real hardware. This reuses the mode the firmware already paired between the drive and the host, without vendor-specific timing code.
-ENOMEDIUM.Scope
Only the PATA (IDE-interface) driver changes. There is no SET FEATURES, no UDMA/MWDMA negotiation, and no vendor timing programming; full-speed DMA still needs chipset-specific support.
Testing
make -j$(nproc)passes.[DMA]/[PIO]mode is logged.