Repository navigation
Fix simultaneous cold startup and release 0.12.2 - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting two freshly extracted copies together can let one process publish and load a WPF mixed-mode assembly between the other's cache check and atomic move. Windows then rejects replacement of the loaded DLL and the second application aborts during startup. This was reproduced from the published 0.12.1 ZIP.
Accept a competing publisher only after verifying the entire cached assembly against the embedded bytes. Missing, unreadable or mismatching files preserve the publication error. Add a deterministic locked-target regression with a same-length mismatching control, document the cache behavior and prepare the user-approved 0.12.2 release. The 0.12.1 tag and assets remain immutable.
Validation: Release build with no warnings/errors; all 3,219 solution tests passed on a private desktop/profile; a fresh read-only adversarial review covered the whole loader, embedding/exclusion targets, startup consumers, package publication/verifier and regression. The actual candidate package passed 20 simultaneous cold-cache GUI pairs, with installed runtime discovery disabled, plus packaged helper version, 112-tool/2-resource discovery, concurrent first calls, reconnect/shutdown, all six compiled MW3 maps and representative native c1 source/valve checks. All 105 compiled and 9,315 native source input hashes were unchanged. The prior release's corpus, all 48 native mission variants and presented GPU checks remain applicable to the unchanged feature code.
Closes #91.