Repository navigation
docs(gha init): pull-request scans withhold the job token and skip the forge pass - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the behaviour shipped in Vulnetix/cli#336:
vulnetix gha initnow renders every scanner step withgithub-tokenwithheld onpull_requestevents, and theanalyzejob passes--no-forgeon pull requests, so pull-request scans no longer drain the repository's shared GitHub API quota (which CodeQL's SARIF upload also uses). Push runs keep the token and the forge pass.The rule is covered by
internal/ghainit/render_test.goin the CLI.