Skip to content

refactor(TeacherAPIController): Extract and refactor TeacherRegistrationAPIController #334

Open
Aaron-Detre wants to merge 4 commits into
developfrom
refactor-teacher-registration
Open

refactor(TeacherAPIController): Extract and refactor TeacherRegistrationAPIController #334
Aaron-Detre wants to merge 4 commits into
developfrom
refactor-teacher-registration

Conversation

@Aaron-Detre

Copy link
Copy Markdown
Contributor

Changes

  • Moved createTeacherAccount method into new TeacherRegistrationAPIController class.
  • Refactored createTeacherAccount and helper methods.
  • Moved related tests into new TeacherRegistrationAPIControllerTest class.

Test

  • Everything should work the same as before. My local environment doesn't have Google/Microsoft accounts or ReCaptcha, so I haven't been able to test those cases. I tried not to change any functionality, so I think it should all still work.
  • A welcome email should still be sent when you create a new account.

@Aaron-Detre Aaron-Detre self-assigned this Jul 17, 2026
@Aaron-Detre Aaron-Detre added the Code Quality Improves code quality label Jul 17, 2026
@Aaron-Detre
Aaron-Detre marked this pull request as ready for review July 17, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Quality Improves code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant