Skip to content
This repository was archived by the owner on Oct 3, 2026. It is now read-only.

Stop Film Club from presenting AI feedback as member endorsement - #24

Merged
WalksWithASwagger merged 4 commits into
mainfrom
codex/issue-14-club-attribution
Sep 6, 2026
Merged

WalksWithASwagger merged 4 commits into
mainfrom
codex/issue-14-club-attribution

Conversation

@WalksWithASwagger

Copy link
Copy Markdown
Owner

Outcome

Closes #14.

Posting Film Club work now saves the full accepted draft with an empty critique list and makes no provider calls. Historical feedback is labeled Legacy AI-generated feedback, with member names identifying only the supplied profile lens; stored critique fields remain intact and endorsement chips are removed. Work above 8,000 characters is rejected instead of silently truncated.

Posting errors retain title/work and re-enable retry; ambiguous network errors warn to check for an existing post before retrying. Loading/refresh errors have a retry state. Club join, empty, hub and homepage copy now describe the actual interim behavior: optional profiles, no automatic feedback or notifications, and no human comments yet. Public copy no longer claims membership-private reading. Removed the orphaned Club generator after repository-wide consumer searches; solo critique is unchanged.

Acceptance evidence

  • Submit-route test uses multiple profiled members, fails/counts any fetch, proves zero provider calls, exact 8,000-character preservation and 8,001-character rejection without a second stored submission.
  • Browser fixtures preserve legacy text, show the explicit AI/profile-lens attribution, omit would-ship endorsement and explain the empty state.
  • Browser checks exercise network and HTTP rejection, retained drafts, successful clearing, keyboard submission, loading/retry and optional-profile joining on desktop and 390px Chromium.
  • Stored room/member/critique schemas, credentials, access and storage implementation are unchanged. Compatibility and rollback limits are documented in docs/film-club.md.

Verification performed

  • npm ci --ignore-scripts
  • npm test: 20 passed.
  • npm run typecheck, npm run lint, npm run build: passed.
  • PLAYWRIGHT_BROWSERS_PATH=/private/tmp/wedges-playwright-browsers npm run test:browser -- --config=/private/tmp/wedges-club-playwright.config.ts: 18 passed. External temporary config changes only the port/base URL to 3194 and resolves the existing test directory; committed defaults remain unchanged. Desktop/mobile screenshots visually inspected.
  • WEDGES_URL=http://127.0.0.1:3195/api/mcp npm run smoke: all deterministic checks passed.
  • WEDGES_SITE_URL=http://127.0.0.1:3195 npm run verify:search: all 30 checks passed.
  • Complete diff review, git diff --cached --check, staged diff piped to gitleaks stdin --redact --no-banner: passed, 32.78KB scanned, no secrets found.

Initial environmental failures: sandbox build could not fetch existing Google Fonts; network-enabled retry passed. Port 3188 was occupied and left untouched; tests used 3194. The temporary browser cache initially lacked the pinned Chromium build; installing it resolved launch failures. New test alert locators initially matched Next's route announcer and were corrected to scope to the main content, then all tests passed. Existing multiple-lockfile warning persists.

Limits

No paid model calls/evals, live Redis writes, production migrations or direct deployment commands performed. The initial branch push triggered an existing automatic Vercel preview (reported pending to the coordinator). A narrowly scoped vercel.json guard now disables automatic deployment only for this branch; the coordinator is handling the initial preview status/cancellation. Production/project settings are unchanged. Human comments, atomic room writes (#18), access migration and idempotent submission are excluded. Current whole-room writes can race, room codes permit reading, and a lost response after persistence can lead to duplicate retry. Safari/Firefox, assistive technology and human feedback quality were not evaluated. All local servers started for these checks were stopped.

@WalksWithASwagger WalksWithASwagger added the review-ready Scoped implementation reviewed and verified; awaits human PR review label Sep 6, 2026
@WalksWithASwagger
WalksWithASwagger merged commit aa4e1e7 into main Sep 6, 2026
1 check passed
@WalksWithASwagger
WalksWithASwagger deleted the codex/issue-14-club-attribution branch September 21, 2026 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

review-ready Scoped implementation reviewed and verified; awaits human PR review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop Film Club from presenting generated feedback as member endorsement

1 participant