This repository was archived by the owner on Oct 3, 2026. It is now read-only.
Repository navigation
Stop Film Club from presenting AI feedback as member endorsement - #24
Merged
Merged
Conversation
5 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Closes #14.
Posting Film Club work now saves the full accepted draft with an empty critique list and makes no provider calls. Historical feedback is labeled Legacy AI-generated feedback, with member names identifying only the supplied profile lens; stored critique fields remain intact and endorsement chips are removed. Work above 8,000 characters is rejected instead of silently truncated.
Posting errors retain title/work and re-enable retry; ambiguous network errors warn to check for an existing post before retrying. Loading/refresh errors have a retry state. Club join, empty, hub and homepage copy now describe the actual interim behavior: optional profiles, no automatic feedback or notifications, and no human comments yet. Public copy no longer claims membership-private reading. Removed the orphaned Club generator after repository-wide consumer searches; solo critique is unchanged.
Acceptance evidence
docs/film-club.md.Verification performed
npm ci --ignore-scriptsnpm test: 20 passed.npm run typecheck,npm run lint,npm run build: passed.PLAYWRIGHT_BROWSERS_PATH=/private/tmp/wedges-playwright-browsers npm run test:browser -- --config=/private/tmp/wedges-club-playwright.config.ts: 18 passed. External temporary config changes only the port/base URL to 3194 and resolves the existing test directory; committed defaults remain unchanged. Desktop/mobile screenshots visually inspected.WEDGES_URL=http://127.0.0.1:3195/api/mcp npm run smoke: all deterministic checks passed.WEDGES_SITE_URL=http://127.0.0.1:3195 npm run verify:search: all 30 checks passed.git diff --cached --check, staged diff piped togitleaks stdin --redact --no-banner: passed, 32.78KB scanned, no secrets found.Initial environmental failures: sandbox build could not fetch existing Google Fonts; network-enabled retry passed. Port 3188 was occupied and left untouched; tests used 3194. The temporary browser cache initially lacked the pinned Chromium build; installing it resolved launch failures. New test alert locators initially matched Next's route announcer and were corrected to scope to the main content, then all tests passed. Existing multiple-lockfile warning persists.
Limits
No paid model calls/evals, live Redis writes, production migrations or direct deployment commands performed. The initial branch push triggered an existing automatic Vercel preview (reported pending to the coordinator). A narrowly scoped
vercel.jsonguard now disables automatic deployment only for this branch; the coordinator is handling the initial preview status/cancellation. Production/project settings are unchanged. Human comments, atomic room writes (#18), access migration and idempotent submission are excluded. Current whole-room writes can race, room codes permit reading, and a lost response after persistence can lead to duplicate retry. Safari/Firefox, assistive technology and human feedback quality were not evaluated. All local servers started for these checks were stopped.