This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
fix(seo): correct Ghost Radio sitemap namespace - #70
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalksWithASwagger
marked this pull request as ready for review
August 16, 2026 06:05
WalksWithASwagger
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed against issue #69 and refreshed onto current main.
Acceptance criteria: the sitemap now uses the exact standard http://www.sitemaps.org/schemas/sitemap/0.9 namespace; the regression assertion would reject the old protocol value; the existing two canonical URLs are unchanged; targeted tests (2), full unit suite (58), typecheck, package build, SEO checker, XML parsing, and diff checks pass. GitHub CI and Vercel are green on head ed4dd897baf1578b37d2c00b81e393e93e269247.
Risks considered and ruled out:
- malformed XML:
xmllint --nooutpasses; - sitemap membership/canonical drift: the functional diff changes only the namespace and the SEO checker retains exactly two URLs;
- player/package regression or scope creep: only
sitemap.xmlandtest/seoCheck.test.tsdiffer from main; - stale-base collision: current main was merged into the branch and the full checks were rerun.
No blocking findings. Ready to merge; production and Search Console verification remain explicit post-merge tasks.
5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #69.
Search Console evidence
Google Search Console auto-verified
https://ghost.radio.fm/via the HTML file and acceptedsitemap.xml. It read the sitemap and discovered two pages, then reported one error:Incorrect namespaceon line 2, tagurlset.The homepage is already indexed.
/classicwasDiscovered - currently not indexed; Google accepted an indexing request and added it to the priority crawl queue.Verification
pnpm exec vitest run test/seoCheck.test.ts— 2 passedpnpm test:run— 58 passedpnpm typecheck— passedpnpm build— passedpnpm check:seo— passed; 2 entrypoints and 3 discovery files verifiedgit diff --check— passedProduction gate
This PR does not merge, deploy, resubmit the sitemap, or claim the Search Console error is cleared. After approved merge and Netlify deployment, verify the live XML namespace and wait for Search Console reprocessing.